Skip to content

Conversation

@wachunei
Copy link
Member

@wachunei wachunei commented Apr 3, 2024

Note

Supersedes #8549

Description

This PR changes the components used in the Settings views of Buy & Sell and adds a label property to the activation keys (not used in production).

Related issues

Fixes #8022
Closes #8549
Fixes https://consensyssoftware.atlassian.net/browse/RAMPS-1490

Manual testing steps

  1. Go to Settings (Development or Ramp UAT build)
  2. Go to Buy and Sell Crypto
  3. Add Activation Key
  4. Edit Activation Key

Screenshots/Recordings

Before

before_activation_keys.mp4

After

after_activation_keys.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features team-design-system All issues relating to design system in Mobile Run Smoke E2E labels Apr 3, 2024
@wachunei wachunei requested a review from a team as a code owner April 3, 2024 14:00
@wachunei wachunei requested a review from a team April 3, 2024 14:00
@wachunei wachunei requested a review from a team as a code owner April 3, 2024 14:00
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f77bd5c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ef56f4ae-3bed-4b2f-9ab5-ae167cc0856c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei force-pushed the feature/ramp-activation-keys-labels branch from f77bd5c to 79006a8 Compare April 3, 2024 14:01
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 89914af
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5dec6625-9e14-495d-bbb4-744b1d5bf621

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei added the needs-ramp-qa Tickets that need feature QA on the ramps flows label Apr 3, 2024
@wachunei wachunei requested a review from a team April 4, 2024 17:19
Copy link
Contributor

@brianacnguyen brianacnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small change requested regarding imports

@wachunei wachunei requested a review from brianacnguyen April 9, 2024 20:58
brianacnguyen
brianacnguyen previously approved these changes Apr 10, 2024
@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 11, 2024
tommasini
tommasini previously approved these changes Apr 26, 2024
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Small nit, it makes sense to keep two components under Settings folder on Ramps folder?

@wachunei wachunei dismissed stale reviews from tommasini and brianacnguyen via 597e5b8 May 2, 2024 21:32
@wachunei
Copy link
Member Author

wachunei commented May 2, 2024

@tommasini @brianacnguyen I had to solve conflicts manually and reviews went stale, would you mind re-approving please 🙏

@wachunei wachunei removed the needs-ramp-qa Tickets that need feature QA on the ramps flows label May 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 441c051
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/458de876-c426-4619-b453-da229c1acb08

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

georgeweiler
georgeweiler previously approved these changes May 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0ed4954
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e043f7c6-d699-470c-9974-5c2cee0270dd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei
Copy link
Member Author

wachunei commented May 8, 2024

@desi please let us know if the translations can make it for today, otherwise we can merge this and bring them in later as agreed yesterday.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2024

@wachunei wachunei merged commit b6bf467 into main May 8, 2024
@wachunei wachunei deleted the feature/ramp-activation-keys-labels branch May 8, 2024 14:54
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2024
@metamaskbot metamaskbot added the release-7.23.0 Issue or pull request that will be included in release 7.23.0 label May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-for-translation This is used in a github action to trigger a branch as ready for translation team to pick up release-7.23.0 Issue or pull request that will be included in release 7.23.0 team-design-system All issues relating to design system in Mobile team-ramp issues related to Ramp features

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Replace Buy Crypto Settings with DS Components

8 participants