-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(ramp): add activation keys labels and DS components #9119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
f77bd5c to
79006a8
Compare
|
brianacnguyen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small change requested regarding imports
tommasini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Small nit, it makes sense to keep two components under Settings folder on Ramps folder?
|
@tommasini @brianacnguyen I had to solve conflicts manually and reviews went stale, would you mind re-approving please 🙏 |
|
|
|
@desi please let us know if the translations can make it for today, otherwise we can merge this and bring them in later as agreed yesterday. |
|



Note
Supersedes #8549
Description
This PR changes the components used in the Settings views of Buy & Sell and adds a label property to the activation keys (not used in production).
Related issues
Fixes #8022
Closes #8549
Fixes https://consensyssoftware.atlassian.net/browse/RAMPS-1490
Manual testing steps
Screenshots/Recordings
Before
before_activation_keys.mp4
After
after_activation_keys.mp4
Pre-merge author checklist
Pre-merge reviewer checklist