Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix for swaps button displaying on unsupported networks (#6473) #6553

Merged
merged 1 commit into from
Jun 7, 2023
Merged

chore: fix for swaps button displaying on unsupported networks (#6473) #6553

merged 1 commit into from
Jun 7, 2023

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Jun 7, 2023 •
edited by sethkfman
Loading

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Cherry-Pick from main to address the swaps button bug #6530

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@cortisiko cortisiko requested a review from a team as a code owner June 7, 2023 18:38
sethkfman
sethkfman approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko changed the title Cherry-Pick: bugfix: fix for swaps button displaying on unsupported networks (#6473) bugfix: fix for swaps button displaying on unsupported networks (#6473) Jun 7, 2023
@cortisiko cortisiko changed the title bugfix: fix for swaps button displaying on unsupported networks (#6473) chore: fix for swaps button displaying on unsupported networks (#6473) Jun 7, 2023
@cortisiko cortisiko merged commit 68f268d into release/7.1.0 Jun 7, 2023
@cortisiko cortisiko deleted the cherry-pick-#6530 branch June 7, 2023 19:22
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2023
@cortisiko cortisiko added the release-7.1.0 Issue or pull request that will be included in release 7.1.0 label Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
release-7.1.0 Issue or pull request that will be included in release 7.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cortisiko @sethkfman @nikoferro