Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: force intel stack on Bitrise builds #6412

Merged
merged 1 commit into from
May 16, 2023
Merged

fix: force intel stack on Bitrise builds #6412

merged 1 commit into from
May 16, 2023

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented May 16, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR cherry picks forcing intel stack on Bitrise builds #6375

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Cal-L Cal-L requested a review from a team as a code owner May 16, 2023 18:36
@Cal-L Cal-L changed the base branch from main to release/6.6.0 May 16, 2023 18:36
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. release-6.6.0 Issue or pull request that will be included in release 6.6.0 team-mobile-client labels May 16, 2023
chrisleewilcox
chrisleewilcox approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit 8153140 into release/6.6.0 May 16, 2023
@chrisleewilcox chrisleewilcox deleted the cherry/fix-bitrise-machine-6.6.0 branch May 16, 2023 18:52
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. release-6.6.0 Issue or pull request that will be included in release 6.6.0 team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cal-L @chrisleewilcox @gauthierpetetin