Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] wallet connect v2 #6355

Merged
merged 15 commits into from
May 12, 2023
Merged

[FEAT] wallet connect v2 #6355

merged 15 commits into from
May 12, 2023

Conversation

abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented May 9, 2023 •
edited
Loading

Description

  • WalletConnect V2 Integration.
  • Compatibility with walletconnect v1.

WALLET_CONNECT_PROJECT_ID needs to be set in js.env

@abretonc7s abretonc7s added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-6.6.0 Issue or pull request that will be included in release 6.6.0 labels May 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@abretonc7s abretonc7s changed the base branch from main to release/6.6.0 May 9, 2023 13:17
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎

🚨 Potential security issues found in this pull request. To accept the risk, merge this PR and you will not be notified again.

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore pino@7.11.0
  • @SocketSecurity ignore thread-stream@0.15.2
  • @SocketSecurity ignore pino-std-serializers@4.0.0
  • @SocketSecurity ignore @walletconnect/auth-client@2.0.7
  • @SocketSecurity ignore @walletconnect/core@2.7.2
  • @SocketSecurity ignore @walletconnect/core@2.7.3
  • @SocketSecurity ignore @walletconnect/react-native-compat@2.7.3
  • @SocketSecurity ignore @walletconnect/se-sdk@1.2.0
  • @SocketSecurity ignore @walletconnect/sign-client@2.7.2
  • @SocketSecurity ignore @walletconnect/types@2.7.2
  • @SocketSecurity ignore @walletconnect/types@2.7.3
  • @SocketSecurity ignore @walletconnect/utils@2.7.2
  • @SocketSecurity ignore @walletconnect/utils@2.7.3
  • @SocketSecurity ignore @walletconnect/web3wallet@1.7.0
  • @SocketSecurity ignore isomorphic-unfetch@3.1.0
  • @SocketSecurity ignore unfetch@4.2.0
  • @SocketSecurity ignore @stablelib/aead@1.0.1
  • @SocketSecurity ignore @stablelib/binary@1.0.1
  • @SocketSecurity ignore @stablelib/bytes@1.0.1
  • @SocketSecurity ignore @stablelib/chacha@1.0.1
  • @SocketSecurity ignore @stablelib/chacha20poly1305@1.0.1
  • @SocketSecurity ignore @stablelib/constant-time@1.0.1
  • @SocketSecurity ignore @stablelib/ed25519@1.0.3
  • @SocketSecurity ignore @stablelib/hash@1.0.1
  • @SocketSecurity ignore @stablelib/hkdf@1.0.1
  • @SocketSecurity ignore @stablelib/hmac@1.0.1
  • @SocketSecurity ignore @stablelib/int@1.0.1
  • @SocketSecurity ignore @stablelib/keyagreement@1.0.1
  • @SocketSecurity ignore @stablelib/poly1305@1.0.1
  • @SocketSecurity ignore @stablelib/random@1.0.2
  • @SocketSecurity ignore @stablelib/sha256@1.0.1
  • @SocketSecurity ignore @stablelib/sha512@1.0.1
  • @SocketSecurity ignore @stablelib/wipe@1.0.1
  • @SocketSecurity ignore @stablelib/x25519@1.0.3
  • @SocketSecurity ignore @walletconnect/events@1.0.1
  • @SocketSecurity ignore @walletconnect/jsonrpc-ws-connection@1.0.11
  • @SocketSecurity ignore @walletconnect/environment@1.0.1
  • @SocketSecurity ignore @walletconnect/jsonrpc-types@1.0.2
  • @SocketSecurity ignore @walletconnect/relay-auth@1.0.4
  • @SocketSecurity ignore @walletconnect/time@1.0.2
  • @SocketSecurity ignore @walletconnect/window-getters@1.0.1
  • @SocketSecurity ignore @walletconnect/window-metadata@1.0.1
  • @SocketSecurity ignore sonic-boom@2.8.0
  • @SocketSecurity ignore @walletconnect/keyvaluestorage@1.0.2
  • @SocketSecurity ignore @walletconnect/jsonrpc-utils@1.0.7
  • @SocketSecurity ignore @walletconnect/safe-json@1.0.2
  • @SocketSecurity ignore @types/qs@6.9.7
  • @SocketSecurity ignore safe-json-utils@1.1.1
  • @SocketSecurity ignore atomic-sleep@1.0.0
  • @SocketSecurity ignore quick-format-unescaped@4.0.4
⚠️ Filesystem access

Accesses the file system, and could potentially read sensitive data.

If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead.

Package Module Location Source
pino@7.11.0 (added) fs test/basic.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/esm/named-exports.mjs package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/final.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/fixtures/to-file-transport-with-transform.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/fixtures/to-file-transport.mjs package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/fixtures/transport/index.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/fixtures/ts/to-file-transport.es2017.cjs package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/fixtures/ts/to-file-transport.es5.cjs package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/fixtures/ts/to-file-transport.es6.cjs package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/fixtures/ts/to-file-transport.esnext.cjs package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/fixtures/ts/transpile.cjs package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/formatters.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/helper.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/multistream.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/syncfalse.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/transport/big.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/transport/bundlers-support.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/transport/core.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/transport/module-link.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/transport/pipeline.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) fs test/transport/syncfalse.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
thread-stream@0.15.2 (added) fs bench.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
thread-stream@0.15.2 (added) fs test/base.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
thread-stream@0.15.2 (added) fs test/end.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
thread-stream@0.15.2 (added) fs test/esm.test.mjs package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
thread-stream@0.15.2 (added) fs test/helper.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
thread-stream@0.15.2 (added) fs test/multibyte-chars.test.mjs package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
thread-stream@0.15.2 (added) fs test/string-limit-2.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
thread-stream@0.15.2 (added) fs test/string-limit.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
thread-stream@0.15.2 (added) fs test/thread-management.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
thread-stream@0.15.2 (added) fs test/to-file-on-destroy.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
thread-stream@0.15.2 (added) fs test/to-file-on-final.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
thread-stream@0.15.2 (added) fs test/to-file.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
thread-stream@0.15.2 (added) fs test/to-file.mjs package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
⚠️ Network access

This module accesses the network.

Packages should remove all network access that isn't functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Package Module Location Source
pino-std-serializers@4.0.0 (added) http test/req.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino-std-serializers@4.0.0 (added) http test/res.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
⚠️ Shell access

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Package Module Location Source
pino@7.11.0 (added) child_process test/broken-pipe.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) child_process test/stdout-protection.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
pino@7.11.0 (added) child_process test/syncfalse.test.js package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
⚠️ No bug tracker

Package does not have a linked bug tracker in package.json.

Add a bugs field to package.json. https://docs.npmjs.com/cli/v8/configuring-npm/package-json#bugs

Package Location Source
@walletconnect/auth-client@2.0.7 (added) package.json package.json via @walletconnect/se-sdk@1.2.0
@walletconnect/core@2.7.2 (added) package.json package.json via @walletconnect/se-sdk@1.2.0
@walletconnect/core@2.7.3 (added) package.json package.json via @walletconnect/se-sdk@1.2.0
@walletconnect/react-native-compat@2.7.3 (added) package.json package.json
@walletconnect/se-sdk@1.2.0 (added) package.json package.json
@walletconnect/sign-client@2.7.2 (added) package.json package.json via @walletconnect/se-sdk@1.2.0
@walletconnect/types@2.7.2 (added) package.json package.json via @walletconnect/se-sdk@1.2.0
@walletconnect/types@2.7.3 (added) package.json package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@walletconnect/utils@2.7.2 (added) package.json package.json via @walletconnect/se-sdk@1.2.0
@walletconnect/utils@2.7.3 (added) package.json package.json via @walletconnect/se-sdk@1.2.0
@walletconnect/web3wallet@1.7.0 (added) package.json package.json via @walletconnect/se-sdk@1.2.0
⚠️ No contributors or author data

Package does not specify a list of contributors or an author in package.json.

Add a author field or contributors array to package.json.

Package Location Source
isomorphic-unfetch@3.1.0 (added) package.json package.json via @walletconnect/se-sdk@1.2.0
unfetch@4.2.0 (added) package.json package.json via @walletconnect/se-sdk@1.2.0
⚠️ No README

Package does not have a README. This may indicate a failed publish or a low quality package.

Add a README to to the package and publish a new version.

Package Location Source
@stablelib/aead@1.0.1 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/binary@1.0.1 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/bytes@1.0.1 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/chacha@1.0.1 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/chacha20poly1305@1.0.1 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/constant-time@1.0.1 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/ed25519@1.0.3 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0
@stablelib/hash@1.0.1 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/hkdf@1.0.1 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/hmac@1.0.1 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/int@1.0.1 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/keyagreement@1.0.1 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/poly1305@1.0.1 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/random@1.0.2 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/sha256@1.0.1 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/sha512@1.0.1 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0
@stablelib/wipe@1.0.1 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/x25519@1.0.3 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@walletconnect/auth-client@2.0.7 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0
@walletconnect/events@1.0.1 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
@walletconnect/jsonrpc-ws-connection@1.0.11 (added) Package overview package.json via @walletconnect/se-sdk@1.2.0
⚠️ New author

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Package New Author Previous Author Source
@walletconnect/environment@1.0.1 (added) bkrem pedrouid package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@walletconnect/events@1.0.1 (added) bkrem pedrouid package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
@walletconnect/jsonrpc-types@1.0.2 (upgraded) bkrem pedrouid package.json via @walletconnect/client@1.7.1, @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
@walletconnect/relay-auth@1.0.4 (added) bkrem pedrouid package.json via @walletconnect/se-sdk@1.2.0
@walletconnect/time@1.0.2 (added) bkrem pedrouid package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
@walletconnect/window-getters@1.0.1 (added) bkrem pedrouid package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@walletconnect/window-metadata@1.0.1 (added) bkrem pedrouid package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
sonic-boom@2.8.0 (added) jsumners matteo.collina package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
@walletconnect/keyvaluestorage@1.0.2 (added) bkrem gancho_walletconnect package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
@walletconnect/jsonrpc-utils@1.0.7 (added) gancho_walletconnect bkrem package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@walletconnect/safe-json@1.0.2 (added) gancho_walletconnect bkrem package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
⚠️ Unmaintained

Package has not been updated in more than a year and may be unmaintained. Problems with the package may go unaddressed.

Package should publish periodic maintenance releases if they are maintained, or deprecate if they have no intention in further maintenance.

Package Last Publish Date Source
@stablelib/hkdf@1.0.1 (added) 5/21/2021, 9:54:00 AM package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/int@1.0.1 (added) 5/21/2021, 9:53:44 AM package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@types/qs@6.9.7 (added) 7/7/2021, 5:21:04 PM package.json
safe-json-utils@1.1.1 (added) 6/22/2021, 1:01:49 PM package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
@stablelib/chacha20poly1305@1.0.1 (added) 5/21/2021, 9:54:04 AM package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/sha512@1.0.1 (added) 5/21/2021, 9:53:58 AM package.json via @walletconnect/se-sdk@1.2.0
@stablelib/poly1305@1.0.1 (added) 5/21/2021, 9:53:52 AM package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/keyagreement@1.0.1 (added) 5/21/2021, 9:53:47 AM package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
atomic-sleep@1.0.0 (added) 3/9/2020, 6:56:01 PM package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/types@2.7.3, @walletconnect/utils@2.7.3
@stablelib/binary@1.0.1 (added) 5/21/2021, 9:53:48 AM package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/bytes@1.0.1 (added) 5/21/2021, 9:53:39 AM package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/hmac@1.0.1 (added) 5/21/2021, 9:53:53 AM package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/hash@1.0.1 (added) 5/21/2021, 9:53:43 AM package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/chacha@1.0.1 (added) 5/21/2021, 9:53:56 AM package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
@stablelib/aead@1.0.1 (added) 5/21/2021, 9:53:38 AM package.json via @walletconnect/se-sdk@1.2.0, @walletconnect/utils@2.7.3
[@stablelib/sha256@1.0.1](https://socket.dev

@abretonc7s abretonc7s marked this pull request as ready for review May 9, 2023 13:56
@abretonc7s abretonc7s requested a review from a team as a code owner May 9, 2023 13:56
sethkfman
sethkfman reviewed May 9, 2023
View reviewed changes
app/core/WalletConnect.js Outdated Show resolved Hide resolved
@christopherferreira9 christopherferreira9 removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label May 9, 2023
@abretonc7s abretonc7s changed the title Feat/wc2 [FEAT] wallet connect v2 May 10, 2023
andreahaku
andreahaku approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreahaku andreahaku added the WalletConnect WalletConnect related issue or bug label May 10, 2023
@christopherferreira9 christopherferreira9 added QA Passed A successful QA run through has been done and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels May 12, 2023
@christopherferreira9 christopherferreira9 merged commit 3911d7c into release/6.6.0 May 12, 2023
@christopherferreira9 christopherferreira9 deleted the feat/wc2 branch May 12, 2023 11:17
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2023
@andreahaku andreahaku restored the feat/wc2 branch May 12, 2023 15:54
@michaelmccallam michaelmccallam removed QA Passed A successful QA run through has been done WalletConnect WalletConnect related issue or bug labels May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman left review comments

@andreahaku andreahaku andreahaku approved these changes

Assignees

@andreahaku andreahaku

@Cal-L Cal-L

@christopherferreira9 christopherferreira9

Labels
release-6.6.0 Issue or pull request that will be included in release 6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@abretonc7s @andreahaku @sethkfman @michaelmccallam @Cal-L @christopherferreira9