fix(predict): use correct payload for dynamic market subscriptions cp-8.3.0

[caieu]

Description

Fixes live price updates for market tokens added after the Polymarket WebSocket connection is already open.

Initial and reconnect subscriptions continue using the market connection payload, while dynamic token additions now use Polymarket's subscribe operation. Previously, dynamically added tokens were sent using the initial connection payload and were not subscribed, preventing components such as moneyline cards and charts from receiving updates.

Regression tests cover dynamic price and orderbook subscriptions while preserving initial and reconnect behavior.

Changelog

CHANGELOG entry: Fixed live prediction market prices not updating for dynamically subscribed markets

Related issues

Refs: https://consensyssoftware.atlassian.net/browse/PRED-1092

Manual testing steps

Feature: Live prediction market prices

  Scenario: Receive updates for tokens added to an open WebSocket connection
    Given a prediction game details page is open
    And the market WebSocket connection is already active

    When moneyline tokens are added to the connection
    Then the moneyline card displays live price updates
    And the moneyline chart displays live price updates

Automated verification:

npx jest app/components/UI/Predict/providers/polymarket/WebSocketManager.test.ts --coverage=false

Screenshots/Recordings

N/A — this change fixes the WebSocket subscription payload and has no visual changes.

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Targeted WebSocket subscription payload fix in Predict Polymarket provider with tests; initial/reconnect behavior unchanged.

Overview
Fixes live prediction market prices when tokens are subscribed after the Polymarket market WebSocket is already open (e.g. moneyline cards/charts on game details).

WebSocketManager now sends { type: 'market', assets_ids } only for the first connection and reconnect resubscribe, and { operation: 'subscribe', assets_ids } when price or orderbook subscriptions are added on an open socket. Previously, dynamic adds reused the initial payload and Polymarket did not subscribe those assets.

Regression tests assert the subscribe payload for late-added market prices and orderbooks.

^{Reviewed by Cursor Bugbot for commit 8c7484e. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokePredictions, SmokeWalletPlatform, SmokeConfirmations
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 90%

click to see 🤖 AI reasoning details

E2E Test Selection:
The PR modifies WebSocketManager.ts in the Polymarket Predictions provider. The change refactors the market subscription logic by:

1. Renaming sendMarketSubscribe → sendInitialMarketSubscription (used when WebSocket first opens)
2. Adding a new sendMarketSubscriptionUpdate method for dynamically subscribing to tokens on an already-open connection
3. Updating ensureMarketConnection to use the new dynamic update method when the connection is already OPEN

This is a functional change to how Polymarket WebSocket subscriptions work — specifically fixing/improving the behavior when subscribing to additional tokens after a connection is already established. This directly impacts the Predictions feature's ability to receive real-time market data.

SmokePredictions is selected as the primary tag since this is core Polymarket functionality. Per the tag description, SmokePredictions requires also selecting SmokeWalletPlatform (Predictions is a section inside Trending tab) and SmokeConfirmations (opening/closing positions are on-chain transactions).

No other areas are affected — this is isolated to the Polymarket WebSocket provider.

Performance Test Selection:
The changes are limited to WebSocket subscription logic refactoring in the Polymarket provider. No performance-sensitive paths are affected — no rendering changes, no balance fetching, no app launch paths, no account list changes. The @PerformancePredict tag covers prediction market list loading and deposit flows, but this WebSocket subscription change is an internal implementation detail that doesn't affect the measured performance scenarios.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
71.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud