test(snaps): Add name-lookup E2E

[FrederikBolding]

Description

Port extension name-lookup test to mobile for increased coverage. The PR adjusts a few shared utilities to make the tests more stable and enable the flow tested in this test.

Changelog

CHANGELOG entry: null

Related issues

Closes: MetaMask/snaps#3572

---

Note

Low Risk
Low risk: changes are limited to Detox E2E test code and test selectors, with a small tap-stability tweak that could affect test flakiness but not app behavior.

Overview
Adds a new smoke E2E test (test-snap-name-lookup.spec.ts) that installs the Name Lookup test snap and verifies a domain recipient resolves to the expected address during the send/confirmation flow.

Extends test infrastructure to support the scenario by adding the connectNameLookupButton selector, adding a tapAdvancedDetails() helper on TransactionConfirmView, and making RedesignedSendView.pressReviewButton() use checkStability when tapping.

^{Written by Cursor Bugbot for commit d3d21a0. This will update automatically on new commits. Configure here.}

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: FlaskBuildTests, SmokeConfirmations
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 90%

click to see 🤖 AI reasoning details

E2E Test Selection:
The PR introduces a new E2E test for the Name Lookup Snap functionality (test-snap-name-lookup.spec.ts) which is explicitly tagged with FlaskBuildTests. This test validates snap-based domain name resolution in the send flow.

Additionally, the PR modifies shared test infrastructure:

1. RedesignedSendView.ts: Added checkStability: true to pressReviewButton() - this is a stability improvement that affects all tests using this method, including confirmation tests (send-erc20-token, send-native-token, gas-fee-tokens)
2. TransactionConfirmView.ts: Added new tapAdvancedDetails() method used by the new snap test
3. TestSnaps.selectors.ts: Added new selector for the name lookup snap button

FlaskBuildTests is required to run the new snap test and validate the snap functionality works correctly.

SmokeConfirmations is selected because the checkStability: true change to pressReviewButton() affects the send flow used by confirmation tests. While this is a stability improvement, running these tests ensures the change doesn't introduce any regressions in the confirmation flow.

Performance Test Selection:
The changes are purely test infrastructure additions (new test file, page object methods, selectors) with no modifications to application code that would affect performance. The checkStability flag is a test stability improvement, not an app performance change. No performance tests are needed.

View GitHub Actions results

[github-actions]

⚠️ E2E Fixture Validation — Structural changes detected

Category	Count
New keys	60
Missing keys	0
Type mismatches	0
Value mismatches	7 (informational)

The committed fixture schema is out of date. To update, comment:

@metamaskbot update-mobile-fixture

View full details | Download diff report

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[christopherferreira9]

LGTM!