Skip to content

Conversation

@runway-github
Copy link
Contributor

@runway-github runway-github bot commented Jul 28, 2025

Description

Fix Not Available in transaction list by ensuring chain specific
tokens and contractExchangeRates selectors are used.

Also poll token rates while transaction view is visible.

Changelog

CHANGELOG entry: Fixed a bug causing "Not Available" entries in
transaction list

Related issues

Fixes: #17102

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots. 77df2b1

…able in transaction list (#17327)

## **Description**

Fix `Not Available` in transaction list by ensuring chain specific
`tokens` and `contractExchangeRates` selectors are used.

Also poll token rates while transaction view is visible.

## **Changelog**

CHANGELOG entry: Fixed a bug causing "Not Available" entries in
transaction list

## **Related issues**

Fixes: #17102 

## **Manual testing steps**

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead label Jul 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 160f428
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9805d600-5c0b-4eb2-802d-b7aeb1c5b0e8

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Tyschenko Tyschenko merged commit cceda87 into release/7.52.0 Jul 28, 2025
54 of 76 checks passed
@Tyschenko Tyschenko deleted the runway-cherry-pick-7.52.0-1753693442 branch July 28, 2025 09:37
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2025
@metamaskbot metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Sep 3, 2025
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants