-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: handle potential undefined primary keyring when the app is locked cp-7.52.0 #17559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
owencraston
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this fixes the crash in my testing.
|
Missing release label release-7.52.0 on PR. Adding release label release-7.52.0 on PR and removing other release labels(release-7.53.0), as PR was cherry-picked in branch 7.52.0. |



Description
This PR fixes the issue where
accountsis undefined when the app auto locks while on the wallet details screen.Changelog
CHANGELOG entry: null
Related issues
Fixes: #17522
Resolves: https://consensyssoftware.atlassian.net/browse/MUL-454?atlOrigin=eyJpIjoiYzMyNDZhYTQxMTBjNGNiYWE3ZWMzMjE5M2JkZjI1MDEiLCJwIjoiaiJ9
Manual testing steps
1 .import a wallet
2. click on the selected account
3. the account list should open
4. click the three dots beside any of your accounts
5. the account details page should open
6. click on the wallet section of the account details page
7. the wallet details page should open
8. do not touch the screen and let your phone screen auto lock
9. wait a few more seconds while the phone is unlocked
10. re open your phone
11. You will see the login screen
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist