Skip to content

Conversation

@montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Jul 24, 2025

Description

This PR fixes the issue where accounts is undefined when the app auto locks while on the wallet details screen.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #17522

Resolves: https://consensyssoftware.atlassian.net/browse/MUL-454?atlOrigin=eyJpIjoiYzMyNDZhYTQxMTBjNGNiYWE3ZWMzMjE5M2JkZjI1MDEiLCJwIjoiaiJ9

Manual testing steps

1 .import a wallet
2. click on the selected account
3. the account list should open
4. click the three dots beside any of your accounts
5. the account details page should open
6. click on the wallet section of the account details page
7. the wallet details page should open
8. do not touch the screen and let your phone screen auto lock
9. wait a few more seconds while the phone is unlocked
10. re open your phone
11. You will see the login screen

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-accounts-framework Accounts Framework team label Jul 24, 2025
@montelaidev montelaidev added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E labels Jul 24, 2025
@montelaidev montelaidev self-assigned this Jul 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 07d5a20
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/66a188f5-4594-4189-926c-707ec64bd1c7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

@montelaidev montelaidev marked this pull request as ready for review July 24, 2025 14:56
@montelaidev montelaidev requested a review from a team as a code owner July 24, 2025 14:56
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixes the crash in my testing.

@owencraston owencraston changed the title fix: handle potential undefined primary keyring when the app is locked. fix: handle potential undefined primary keyring when the app is locked cp-7.52.0 Jul 24, 2025
@montelaidev montelaidev enabled auto-merge July 24, 2025 15:02
@montelaidev montelaidev added this pull request to the merge queue Jul 24, 2025
Merged via the queue into main with commit 0730f68 Jul 24, 2025
71 of 75 checks passed
@montelaidev montelaidev deleted the fix/17522 branch July 24, 2025 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 24, 2025
@metamaskbot metamaskbot added release-7.52.0 Issue or pull request that will be included in release 7.52.0 and removed release-7.53.0 Issue or pull request that will be included in release 7.53.0 labels Sep 3, 2025
@metamaskbot
Copy link
Collaborator

Missing release label release-7.52.0 on PR. Adding release label release-7.52.0 on PR and removing other release labels(release-7.53.0), as PR was cherry-picked in branch 7.52.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-accounts-framework Accounts Framework team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Wallet details crash after being backgrounded

4 participants