Skip to content

Conversation

@sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Jul 18, 2025

Description

This PR fixes the RC (Release Candidate) build workflows in bitrise.yml that were incorrectly using production build configurations instead of the appropriate RC configurations.

What is the reason for the change?
The RC build workflows and were calling production build steps ( and ) instead of the RC-specific build steps.

What is the improvement/solution?
Updated the workflows to use the correct RC build configurations:

  • now calls build_android_main_rc
  • now calls build_ios_main_rc

Also removed obsolete TODO comments that were no longer relevant.

Changelog

CHANGELOG entry: null

Related issues

Fixes: N/A

Manual testing steps

  1. Trigger an RC build via Bitrise
  2. Verify that the RC build uses the correct RC configurations
  3. Confirm that the generated apps have RC-specific settings

Screenshots/Recordings

N/A - Build configuration changes only

Before

RC builds were using production configurations

After

RC builds now use the correct RC configurations

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Jul 18, 2025
@sethkfman sethkfman added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed labels Jul 18, 2025
@sethkfman sethkfman marked this pull request as ready for review July 18, 2025 16:36
@sethkfman sethkfman requested a review from a team July 18, 2025 16:36
@sonarqubecloud
Copy link

@sethkfman sethkfman added this pull request to the merge queue Jul 18, 2025
Merged via the queue into main with commit 71e059f Jul 18, 2025
62 of 65 checks passed
@sethkfman sethkfman deleted the fix/rc-build-steps branch July 18, 2025 17:16
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 18, 2025
@metamaskbot metamaskbot added release-7.52.0 Issue or pull request that will be included in release 7.52.0 and removed release-7.53.0 Issue or pull request that will be included in release 7.53.0 labels Sep 3, 2025
@metamaskbot
Copy link
Collaborator

Missing release label release-7.52.0 on PR. Adding release label release-7.52.0 on PR and removing other release labels(release-7.53.0), as PR was cherry-picked in branch 7.52.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants