Skip to content

fix: Remove password input on backup SRP cp-7.52.0 #17363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chaitanyapotti merged 4 commits into from
Jul 20, 2025
Merged

fix: Remove password input on backup SRP cp-7.52.0 #17363

chaitanyapotti merged 4 commits into from
Jul 20, 2025

Conversation

@smgv
Copy link
Contributor

@smgv smgv commented Jul 18, 2025 •
edited
Loading

Description

  • Removed the Confirm Password screen while creating the wallet using SRP confirmation flow

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to the app.
  2. Click on Create Wallet
  3. Continue with the SRP flow

Screenshots/Recordings

Before

After

iOS:

Screen.Recording.2025-07-18.at.4.19.58.PM.mov
Screen.Recording.2025-07-18.at.4.21.37.PM.mov

Android:

Screen.Recording.2025-07-18.at.4.24.45.PM.mov
Screen.Recording.2025-07-18.at.4.26.07.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@smgv smgv requested a review from chaitanyapotti July 18, 2025 11:01
@smgv smgv self-assigned this Jul 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Jul 18, 2025
@smgv smgv requested a review from ieow July 18, 2025 11:01
@smgv smgv added area-onboarding needs-qa Any New Features that needs a full manual QA prior to being added to a release. Run Smoke E2E labels Jul 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3bc36f7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c3b5fd82-10d6-4212-908b-aae2baf8bb19

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@chaitanyapotti chaitanyapotti changed the title fix: Remove password input on backup SRP fix: Remove password input on backup SRP cp-7.52.0 Jul 18, 2025
@LeVinhGithub LeVinhGithub added QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 18, 2025
@LeVinhGithub
Copy link
Contributor

LeVinhGithub commented Jul 18, 2025

lgtm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b82dca3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e24d438f-5d1f-481d-bca7-bd66abd4a908

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 18, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chaitanyapotti chaitanyapotti added this pull request to the merge queue Jul 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 20, 2025
@chaitanyapotti chaitanyapotti added this pull request to the merge queue Jul 20, 2025
Merged via the queue into main with commit 1b6ee57 Jul 20, 2025
56 of 58 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/password-input-backup-srp branch July 20, 2025 06:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 20, 2025
@metamaskbot metamaskbot added release-7.52.0 Issue or pull request that will be included in release 7.52.0 and removed release-7.53.0 Issue or pull request that will be included in release 7.53.0 labels Sep 3, 2025
@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 7, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

10 similar comments
@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 8, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 8, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 14, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Oct 20, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

@metamaskbot
Copy link
Collaborator

metamaskbot commented Nov 4, 2025

No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

@ieow ieow Awaiting requested review from ieow

Assignees

@smgv smgv

Labels

area-onboarding QA Passed QA testing has been completed and passed release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-onboarding Onboarding team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@smgv @LeVinhGithub @metamaskbot @chaitanyapotti @hieu-w