Skip to content

fix: ensure info network modal is focused to render content #17279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Jul 16, 2025

Description

PATCH - adds in fix from main https://github.com/MetaMask/metamask-mobile/pull/15363/files#diff-d6bf3611049fa2d0fd3a59853532cdfa6b92d35d2af5168a438677f3391a7ba3

This resolves the issue on IOS where the InfoNetworkModal was not visible and blocked the UI.

Changelog

CHANGELOG entry: ensure InfoNetworkModal visibility when switching networks on IOS.

Related issues

Fixes: #17244

Manual testing steps

  1. select network selector on wallet view
  2. Add "Additional Network"
  3. Expected - the app should display the expected modals and the app should not be frozen

Screenshots/Recordings

Before

After

https://www.loom.com/share/342c16f8d7d64822ae4d7d523ef374d1?sid=89c6deae-94e9-4e1a-8748-667c07668e32

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Prithpal-Sooriya Prithpal-Sooriya added the Run Smoke E2E Requires smoke E2E testing label Jul 16, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Jul 16, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c185fad
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/52124834-578a-4186-a076-216bc512a23f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review July 16, 2025 14:25
@tommasini tommasini merged commit c0fce5b into release/7.50.2 Jul 16, 2025
55 of 57 checks passed
@tommasini tommasini deleted the fix/info-network-modal-ios-fix branch July 16, 2025 14:39
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Run Smoke E2E Requires smoke E2E testing team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants