Skip to content

Conversation

@huggingbot
Copy link
Member

@huggingbot huggingbot commented Jul 14, 2025

Description

This PR implements user-consent-based error reporting functionality that allows users to opt-in to sending error reports to Sentry even when Sentry tracking is not globally enabled. When critical errors occur in authentication flows, users will be prompted to consent to sharing the error report to help improve the app.

Key improvements:

  • User consent mechanism for error reporting when Sentry is disabled

What is the reason for the change?
To provide users with the option to contribute to app improvement by sharing error reports when they encounter issues, while maintaining full control over their data sharing preferences.

What is the improvement/solution?
Implementation of a consent-based error reporting system that prompts users to voluntarily share error information when critical issues occur, enabling better debugging and app improvement without compromising user privacy.

Changelog

CHANGELOG entry: Added optional error reporting with user consent to help improve app stability

Related issues

Fixes:

Manual testing steps

<prerequisite: disable authentication API>

  1. Ensure Sentry is disabled in app settings
  2. Navigate to Login screen and trigger an error scenario
  3. Verify that user is prompted to consent to sending error report
  4. Test both "Send report" and "Try again" options in the consent dialog
  5. Repeat for ChoosePassword and Onboarding error scenarios
  6. Verify that error reports are only sent when user consents
  7. Confirm that normal app functionality continues regardless of user choice

UI :

Screenshot 2025-07-21 at 1 46 07 PM

ieow and others added 30 commits June 26, 2025 11:26
remove unwanted lint changes
- Added OnboardingSheet component for user onboarding options.
- Integrated AccountStatus component to handle existing account scenarios.
- Updated navigation routes to include new onboarding flows.
- Enhanced ChoosePassword component to support OAuth login success handling.
- Updated localization files to include new strings for onboarding and account status.
- Added tests for new components and updated existing tests for integration.

This commit enhances the user experience during onboarding and account management by providing clear options and feedback for existing users.
@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8ada7bc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bc10b6f7-c989-41b1-9dcc-478d693fbb43

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4e79cc1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ddf5b3fb-9a12-4829-997c-4e57d7744251

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 37657bc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4fdb1a2b-3644-4aea-8b5c-e52d6fd62ef3

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 29b6f9e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9802509a-1cca-4637-97b5-eac40f8e8931

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

Copy link
Contributor

@hieu-w hieu-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huggingbot huggingbot added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit 7029796 Jul 23, 2025
55 of 58 checks passed
@huggingbot huggingbot deleted the feat/sentry-error-integration branch July 23, 2025 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 23, 2025
@metamaskbot metamaskbot added release-7.52.0 Issue or pull request that will be included in release 7.52.0 and removed release-7.53.0 Issue or pull request that will be included in release 7.53.0 labels Sep 3, 2025
@metamaskbot
Copy link
Collaborator

Missing release label release-7.52.0 on PR. Adding release label release-7.52.0 on PR and removing other release labels(release-7.53.0), as PR was cherry-picked in branch 7.52.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-onboarding INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.52.0 Issue or pull request that will be included in release 7.52.0 team-onboarding Onboarding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants