feat: 2.12 backup keyring key instead of password cp-7.52.0 #17106
Conversation
update with quick crypto lib
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** As requirement to match parity with extension, the client Id need to be move out from config to env This pr delete the client ids in the config file and add remapping of the env variable for the buildtype <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
default js.env.example for seedless-onboarding set to false
fix apple bff
fix apple bff
chaitanyapotti
changed the title
chaitanyapotti
changed the title
chaitanyapotti
changed the title
matthiasgeihs
dismissed
their stale review
all required comments have been addressed.
we should make sure that in the future we don't have PRs with 100s of commits.
it's super hard to get an overview of the open review comments because this PR web page is bloated with commit messages.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-7.53.0
metamaskbot
added
release-7.52.0
|
Missing release label release-7.52.0 on PR. Adding release label release-7.52.0 on PR and removing other release labels(release-7.53.0), as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
12 similar comments
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
|
No release label on PR. Adding release label release-7.52.0 on PR, as PR was cherry-picked in branch 7.52.0. |
Description
Previously, seedless onboarding was backing up the keyring password to allow for vault recovery after a password change. Now we backup the keyring encryption key.
See the https://github.com/MetaMask/decisions/pull/85 for more details.
This is part of the implementation of option 6.
This PR update with seedless controller v2 as well
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist