Skip to content

feat(deposit): error view #16947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wachunei merged 11 commits into from
Jul 9, 2025
Merged

feat(deposit): error view #16947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
29e91d5
feat: deposit ErrorView component
AxelGes Jul 4, 2025
98ce1cb
Merge branch 'main' of https://github.com/MetaMask/metamask-mobile in…
AxelGes Jul 9, 2025
f8d1087
feat: use errorView in orderDetails
AxelGes Jul 9, 2025
85e5d90
feat: add tests for deposit ErrorView
AxelGes Jul 9, 2025
a107470
fix: update snapshots
AxelGes Jul 9, 2025
1aed7fc
feat: cleanup errorview
AxelGes Jul 9, 2025
7a83a8b
Merge branch 'main' of https://github.com/MetaMask/metamask-mobile in…
AxelGes Jul 9, 2025
9dcb41e
fix: update tests
AxelGes Jul 9, 2025
53e5b73
refactor(deposit): error view
wachunei Jul 9, 2025
463eed1
feat: -
AxelGes Jul 9, 2025
e8d02d1
fix: update orderdetails snapshot
AxelGes Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions app/components/UI/Ramp/Deposit/Views/DepositOrderDetails/DepositOrderDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { useTheme } from '../../../../../../util/theme';
import Logger from '../../../../../../util/Logger';
import { RootState } from '../../../../../../reducers';
import { FIAT_ORDER_STATES } from '../../../../../../constants/on-ramp';
import ErrorView from '../../../Aggregator/components/ErrorView';
import ErrorView from '../../components/ErrorView';
import useInterval from '../../../../../hooks/useInterval';
import AppConstants from '../../../../../../core/AppConstants';
import DepositOrderContent from '../../components/DepositOrderContent/DepositOrderContent';
Expand Down Expand Up @@ -91,7 +91,10 @@ const DepositOrderDetails = () => {
'FiatOrders::DepositOrderDetails error while processing order',
order,
});
setError((fetchError as Error).message || 'An error as occurred');
setError(
(fetchError as Error).message ||
strings('deposit.order_details.error_message'),
);
} finally {
if (fromInterval) {
setIsRefreshingInterval(false);
Expand Down Expand Up @@ -142,9 +145,9 @@ const DepositOrderDetails = () => {
<ScreenLayout>
<ScreenLayout.Body>
<ErrorView
title={strings('deposit.order_details.error_title')}
description={error}
ctaOnPress={handleOnRefresh}
location="Order Details Screen"
/>
</ScreenLayout.Body>
</ScreenLayout>
Expand Down
Loading
Loading