Skip to content

feat: add xrpl logos #16859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 2, 2025
Merged

feat: add xrpl logos #16859

merged 5 commits into from
Jul 2, 2025

Conversation

saraantole
Copy link
Contributor

@saraantole saraantole commented Jul 2, 2025

Description

This PR adds network logo and native token logo for XRPL network.

Related issues

Fixes:

Manual testing steps

  1. Go to the MetaMask Mobile app
  2. Navigate to the "Networks" section and find the network
  3. Confirm that the network logo is displayed correctly
  4. Add the network as a custom token (if not preloaded)
  5. Verify that the network token logo appears as expected

Screenshots/Recordings

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jul 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@saraantole saraantole added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 2, 2025
@saraantole saraantole marked this pull request as ready for review July 2, 2025 10:28
Copy link

sonarqubecloud bot commented Jul 2, 2025

@vivek-consensys vivek-consensys added QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 2, 2025
@saraantole saraantole added the No E2E Smoke Needed If the PR does not need E2E smoke test run label Jul 2, 2025
@saraantole saraantole enabled auto-merge July 2, 2025 12:53
@saraantole saraantole added this pull request to the merge queue Jul 2, 2025
Merged via the queue into main with commit 1c75914 Jul 2, 2025
56 of 59 checks passed
@saraantole saraantole deleted the add-network-logos branch July 2, 2025 13:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2025
@metamaskbot metamaskbot added the release-7.51.0 Issue or pull request that will be included in release 7.51.0 label Jul 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run QA Passed QA testing has been completed and passed release-7.51.0 Issue or pull request that will be included in release 7.51.0 team-network-enablement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants