Skip to content

feat: migrate BSC network RPC to bsc-mainnet.infura.io #16824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 21, 2025

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Jul 1, 2025

Description

This PR introduces a migration to replace the Base network RPC URL (https://bsc-dataseed.binance.org/) with the new Infura RPC URL (https://bsc-mainnet.infura.io/v3/{infuraProjectId}) in the MetaMask state.

Acceptance Criteria:

  • Migrate BSC Mainnet to Infura only if users are using an Infura RPC as the default on at least one added network, excluding testnets and Linea Mainnet.

same PR was opened on extension

Related issues

Fixes:

Manual testing steps

  1. run a build on main
  2. switch to this branch
  3. check the rpc url used by bsc mainnet

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jul 1, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb force-pushed the salim/migrate-bsc-rpc branch from 3604460 to 7971e48 Compare July 1, 2025 09:41
@salimtb salimtb added the Run Smoke E2E Requires smoke E2E testing label Jul 1, 2025
Copy link
Contributor

github-actions bot commented Jul 1, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 7971e48
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/39597161-7a59-4478-a271-3ead85c985db

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb force-pushed the salim/migrate-bsc-rpc branch from 7971e48 to 93a95a6 Compare July 1, 2025 10:47
@salimtb salimtb marked this pull request as ready for review July 1, 2025 10:48
@salimtb salimtb requested a review from a team July 1, 2025 10:48
@salimtb salimtb added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jul 1, 2025
Copy link
Contributor

github-actions bot commented Jul 1, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 93a95a6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f9a71675-ad7e-43b1-b18c-91449d46ad84

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@salimtb salimtb added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jul 8, 2025
Copy link
Contributor

github-actions bot commented Jul 8, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: eae360e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d5474939-222c-44b6-b9c6-08ff2ef3f219

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

@salimtb salimtb removed the Run Smoke E2E Requires smoke E2E testing label Jul 20, 2025
@salimtb salimtb added the Run Smoke E2E Requires smoke E2E testing label Jul 20, 2025
Copy link
Contributor

github-actions bot commented Jul 20, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3249521
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c989afed-54ac-4deb-9e2c-5690d7071341

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb requested a review from Prithpal-Sooriya July 20, 2025 16:03
@salimtb salimtb added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jul 21, 2025
@salimtb salimtb added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jul 21, 2025
Copy link
Contributor

github-actions bot commented Jul 21, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 95ab626
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/333ea6d5-add4-4a8b-be5f-8ae460722888

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

@salimtb salimtb added this pull request to the merge queue Jul 21, 2025
Merged via the queue into main with commit 72e4fcc Jul 21, 2025
53 checks passed
@salimtb salimtb deleted the salim/migrate-bsc-rpc branch July 21, 2025 11:14
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 21, 2025
@salimtb salimtb changed the title feat: migrate BSC network RPC to bsc-mainnet.infura.io feat: cp-7.52.0 migrate BSC network RPC to bsc-mainnet.infura.io Jul 24, 2025
@salimtb salimtb changed the title feat: cp-7.52.0 migrate BSC network RPC to bsc-mainnet.infura.io feat: migrate BSC network RPC to bsc-mainnet.infura.io Jul 24, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. release-7.53.0 Issue or pull request that will be included in release 7.53.0 Run Smoke E2E Requires smoke E2E testing team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants