Skip to content

feat(deposit): International KYC #16768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 1, 2025
Merged

Conversation

georgeweiler
Copy link
Contributor

@georgeweiler georgeweiler commented Jun 27, 2025

Description

This PR adds a number of internationalization improvements to the KYC forms.

  • Moves the selected region to the deposit context
  • Adds International phone input
  • Hide SSN input for Non-US
  • Date formatting

phone-input-1
phone-input-2

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label Jun 27, 2025
@georgeweiler georgeweiler changed the title International phone input feat(deposit): International KYC Jun 27, 2025
@georgeweiler georgeweiler mentioned this pull request Jun 27, 2025
7 tasks
@georgeweiler georgeweiler added QA Passed QA testing has been completed and passed No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Requires smoke E2E testing and removed QA Passed QA testing has been completed and passed labels Jun 27, 2025
Copy link
Contributor

github-actions bot commented Jun 27, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b259262
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/26809160-49dc-49ee-ba5c-1db5d8de8c0e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@georgeweiler georgeweiler added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 30, 2025
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 94d86b5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0e562892-ef6e-4097-ba4a-3965edb5b95d

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@georgeweiler georgeweiler added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 30, 2025
Copy link
Contributor

github-actions bot commented Jun 30, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5897cc6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/94699515-4c09-4642-9d50-86b867efc5e9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@georgeweiler georgeweiler marked this pull request as ready for review June 30, 2025 18:06
@georgeweiler georgeweiler requested a review from a team as a code owner June 30, 2025 18:06
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@georgeweiler georgeweiler added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Jun 30, 2025
@georgeweiler
Copy link
Contributor Author

skipping sonarcloud because it is incorrect about the constant file duplication.

https://sonarcloud.io/component_measures?id=metamask-mobile&pullRequest=16768&metric=new_duplicated_lines_density&view=list

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Currency Setting for Iceland

Iceland's currency is incorrectly set to EUR; it should be ISK (Icelandic Króna). Iceland is not part of the Eurozone, and this factual error will cause incorrect currency handling and display for Icelandic users.

app/components/UI/Ramp/Deposit/constants.ts#L265-L267

},
currency: 'EUR',
supported: true,

Fix in Cursor


Was this report helpful? Give feedback by reacting with 👍 or 👎

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
67.5% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

@georgeweiler georgeweiler added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit 6ddee8b Jul 1, 2025
41 of 43 checks passed
@georgeweiler georgeweiler deleted the international-phone-input-2 branch July 1, 2025 14:59
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2025
@metamaskbot metamaskbot added the release-7.51.0 Issue or pull request that will be included in release 7.51.0 label Jul 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.51.0 Issue or pull request that will be included in release 7.51.0 Run Smoke E2E Requires smoke E2E testing skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants