-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat(deposit): International KYC #16768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…national-phone-input-2
…national-phone-input-2
…amask-mobile into international-phone-input-2
…national-phone-input-2
|
|
|
app/components/UI/Ramp/Deposit/components/DepositPhoneField/DepositPhoneField.test.tsx
Outdated
Show resolved
Hide resolved
…amask-mobile into international-phone-input-2
skipping sonarcloud because it is incorrect about the constant file duplication. |
app/components/UI/Ramp/Deposit/components/DepositPhoneField/DepositPhoneField.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Incorrect Currency Setting for Iceland
Iceland's currency is incorrectly set to EUR; it should be ISK (Icelandic Króna). Iceland is not part of the Eurozone, and this factual error will cause incorrect currency handling and display for Icelandic users.
app/components/UI/Ramp/Deposit/constants.ts#L265-L267
metamask-mobile/app/components/UI/Ramp/Deposit/constants.ts
Lines 265 to 267 in b319ea6
}, | |
currency: 'EUR', | |
supported: true, |
Was this report helpful? Give feedback by reacting with 👍 or 👎
|
Description
This PR adds a number of internationalization improvements to the KYC forms.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist