Skip to content

feat: add preference for user to enable smart account opt-in #16745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 3, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jun 27, 2025

Description

Adding preference for user to opt in for smart account upgrade. It will be enabled by default for new users.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5235

Manual testing steps

  1. Go to advance settings and opt in for smart account upgrade
  2. Splash pages should no longer be visible for the user when submitting batch request

Screenshots/Recordings

Screenshot 2025-07-02 at 3 43 18 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri requested a review from a team June 27, 2025 12:13
@jpuri jpuri added the team-confirmations Push issues to confirmations team label Jun 27, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Jun 27, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​preferences-controller@​18.2.0 ⏵ 18.4.099 +210073 +198 +4100

View full report

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments

@jpuri jpuri added the DO-NOT-MERGE Pull requests that should not be merged label Jun 30, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.36%. Comparing base (d838bb0) to head (4a3193e).
Report is 48 commits behind head on main.

Files with missing lines Patch % Lines
app/store/migrations/088.ts 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16745      +/-   ##
==========================================
+ Coverage   72.19%   72.36%   +0.17%     
==========================================
  Files        2686     2703      +17     
  Lines       58160    58665     +505     
  Branches     9129     9221      +92     
==========================================
+ Hits        41989    42455     +466     
- Misses      13498    13528      +30     
- Partials     2673     2682       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jpuri jpuri requested review from a team as code owners July 2, 2025 09:45
@jpuri jpuri changed the title Bump @metamask+preferences-controller to 18.4.0 feat: add preference for user to enable smart account opt-in Jul 2, 2025
@jpuri jpuri removed the DO-NOT-MERGE Pull requests that should not be merged label Jul 2, 2025
@jpuri jpuri requested a review from Cal-L July 2, 2025 10:56
Cal-L
Cal-L previously approved these changes Jul 2, 2025
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

darkwing
darkwing previously approved these changes Jul 2, 2025
@jpuri jpuri added the Run Smoke E2E Requires smoke E2E testing label Jul 3, 2025
Copy link
Contributor

github-actions bot commented Jul 3, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b14cdcc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b114db75-ac5c-40b0-98fc-aa25cac7e28d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

OGPoyraz
OGPoyraz previously approved these changes Jul 3, 2025
@jpuri jpuri added No E2E Smoke Needed If the PR does not need E2E smoke test run and removed Run Smoke E2E Requires smoke E2E testing labels Jul 3, 2025
@jpuri jpuri added this pull request to the merge queue Jul 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 3, 2025
@jpuri jpuri dismissed stale reviews from darkwing, OGPoyraz, and Cal-L via 6f7a016 July 3, 2025 09:16
Copy link

sonarqubecloud bot commented Jul 3, 2025

@jpuri jpuri requested review from darkwing and Cal-L July 3, 2025 11:43
@jpuri jpuri enabled auto-merge July 3, 2025 11:43
@jpuri jpuri added this pull request to the merge queue Jul 3, 2025
Merged via the queue into main with commit 344138e Jul 3, 2025
42 of 43 checks passed
@jpuri jpuri deleted the preference_ctrl_bump branch July 3, 2025 13:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2025
@metamaskbot metamaskbot added the release-7.51.0 Issue or pull request that will be included in release 7.51.0 label Jul 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run release-7.51.0 Issue or pull request that will be included in release 7.51.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants