-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: add preference for user to enable smart account opt-in #16745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…tamask-mobile into preference_ctrl_bump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left comments
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16745 +/- ##
==========================================
+ Coverage 72.19% 72.36% +0.17%
==========================================
Files 2686 2703 +17
Lines 58160 58665 +505
Branches 9129 9221 +92
==========================================
+ Hits 41989 42455 +466
- Misses 13498 13528 +30
- Partials 2673 2682 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
Description
Adding preference for user to opt in for smart account upgrade. It will be enabled by default for new users.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5235
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist