Skip to content

feat: Add account from wallet details #16685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 27, 2025
Merged

feat: Add account from wallet details #16685

merged 15 commits into from
Jun 27, 2025

Conversation

owencraston
Copy link
Contributor

@owencraston owencraston commented Jun 25, 2025 •
edited
Loading

Description

  • This PR adds the ability to add an account directly in the wallet details page. There is no confirmation of the SRP since we have context of which srp the user is intending to add the account from. This button should only be present for wallets that have an entropy source.
  • Adding an account from this screen skips name confirmation.

Figma designs

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-257

Manual testing steps

  1. This feature is hidden behind a remote feature flag so to enable it you will either need to use a proxy (message me for details) or have this function return true as well as this one.
  2. Create a wallet
  3. do not backup your SRP
  4. Open the account list.
  5. Since the multi-chain accounts state 1 feature flag is enabled, you should see your accounts grouped by wallet
  6. click on the blue details icon beside the wallet name
  7. it should take you to the wallet details screen
  8. Add the end of your account list, you should see a button to add an account
  9. click this button and then a popup should appear with the option to add an eth or a sol account
  10. click either option
  11. a new account should be created and added to your account list with the default name
  12. repeat the same step with the other network (either SOL or ETH)
  13. navigate back to the the account list and you should see your new accounts added
  14. import a private key
  15. navigate to the private key wallet details
  16. you should not see the option to add an account

Screenshots/Recordings

Before

After

Screen.Recording.2025-06-27.at.12.05.55.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@owencraston owencraston marked this pull request as ready for review June 26, 2025 22:24
@owencraston owencraston requested review from a team as code owners June 26, 2025 22:24
@owencraston owencraston added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Requires smoke E2E testing labels Jun 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 26, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 59a0592
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dbe84f3e-e323-4a28-9d7f-20de81a21621

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@owencraston owencraston added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 2197978
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/18e35b2c-1714-47f7-a236-f6605c482a98

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

NidhiKJha
NidhiKJha previously approved these changes Jun 27, 2025
View reviewed changes
@owencraston owencraston added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b0ea2c5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c0931210-3598-483e-8981-8c3f6fea50f1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Andepande
Andepande approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@owencraston owencraston added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 27, 2025
@owencraston owencraston added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 27, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b16e235
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46f03b62-f3ff-4a88-ac87-dd87e9982862

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@owencraston owencraston enabled auto-merge June 27, 2025 13:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
83.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@owencraston owencraston added this pull request to the merge queue Jun 27, 2025
Merged via the queue into main with commit 72b0afb Jun 27, 2025
53 of 56 checks passed
@owencraston owencraston deleted the feat/mul-257 branch June 27, 2025 14:04
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2025
@metamaskbot metamaskbot added the release-7.51.0 Issue or pull request that will be included in release 7.51.0 label Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PatrykLucka PatrykLucka PatrykLucka approved these changes

@NidhiKJha NidhiKJha NidhiKJha approved these changes

+1 more reviewer

@Andepande Andepande Andepande approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@owencraston owencraston

Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.51.0 Issue or pull request that will be included in release 7.51.0 Run Smoke E2E Requires smoke E2E testing team-accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@owencraston @PatrykLucka @NidhiKJha @Andepande @metamaskbot