feat: change contacts logic in order to support global network selector removal

[mathieuartu]

Description

This PR makes it so the contacts feature supports the future removal of the global network selector.
Namely, with this PR:

• Every EVM contact is displayed in the contacts page, with an added network badge
• Every EVM contact is displayed in the send flow
• A network selector can be used when adding or editing a contact
• Network badges are also shown in the send flow address book

By itself, this PR introduces no user facing changes, because new logic is behind the MM_REMOVE_GLOBAL_NETWORK_SELECTOR feature flag. This flag is false by default.

In order to test this PR changes, you'd need to temporarily modify app/util/networks/index.js so that isRemoveGlobalNetworkSelectorEnabled returns true.

Related issues

Fixes:

• https://github.com/MetaMask/MetaMask-planning/issues/4112
• https://github.com/MetaMask/MetaMask-planning/issues/4177

Manual testing steps

1. Enable the MM_REMOVE_GLOBAL_NETWORK_SELECTOR feature flag (see description above)
2. Go to the contacts page
3. Verify that every contact has a network badge
4. Add or edit a contact
5. Verify that you can select the network
6. Go to the send flow
7. Verify that all EVM contacts are displayed
8. Verify that those contacts have a network badge

Screenshots/Recordings

Before

After

contacts_2.mov

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: be795d1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cd70be6b-a636-4891-bfef-3a9a758ecf3c

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 581c089
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9af95c14-98ee-45a0-84f7-d94528a0f007

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[mathieuartu]

A custom Bitrise pipeline where process.env. MM_REMOVE_GLOBAL_NETWORK_SELECTOR is true has been run successfully here

[cmd-ob]

I have done a manual pass confirming the functionality as described in the PR description

[vinnyhoward]

Code looks solid. Approving now. I'll do some manual testing this afternoon. I'll ping you if I find anything