Skip to content

feat(deposit): adds region selector to deposit page #16478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jun 19, 2025

Conversation

georgeweiler
Copy link
Contributor

@georgeweiler georgeweiler commented Jun 18, 2025

Description

This PR adds a region selector to the Deposit build quote page.

regions

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

georgeweiler and others added 24 commits June 10, 2025 14:18
…amask-mobile into feat/deposit/build-quote-ui
…mask-mobile into feat/deposit/build-quote-ui
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgeweiler georgeweiler added team-ramp issues related to Ramp features No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Requires smoke E2E testing labels Jun 19, 2025
@georgeweiler georgeweiler marked this pull request as ready for review June 19, 2025 17:48
@georgeweiler georgeweiler requested a review from a team as a code owner June 19, 2025 17:48
Copy link
Contributor

github-actions bot commented Jun 19, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0948a4e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/190a0a53-3824-45f6-81cc-b9c65b40fdd8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2025

Codecov Report

Attention: Patch coverage is 77.33333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 71.89%. Comparing base (a791da1) to head (28c8e20).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...amp/Deposit/components/RegionModal/RegionModal.tsx 83.63% 5 Missing and 4 partials ⚠️
...ts/UI/Ramp/Deposit/Views/BuildQuote/BuildQuote.tsx 56.25% 3 Missing and 4 partials ⚠️
...posit/components/RegionModal/regionModal.styles.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16478      +/-   ##
==========================================
+ Coverage   71.87%   71.89%   +0.02%     
==========================================
  Files        2654     2656       +2     
  Lines       57185    57292     +107     
  Branches     8926     8942      +16     
==========================================
+ Hits        41099    41191      +92     
- Misses      13472    13476       +4     
- Partials     2614     2625      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@georgeweiler georgeweiler added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 19, 2025
Copy link
Contributor

github-actions bot commented Jun 19, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d1534da
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f20aac51-c996-4ab9-97ba-7c1a5574eac5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@georgeweiler georgeweiler added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 19, 2025
@georgeweiler georgeweiler enabled auto-merge June 19, 2025 19:42
@georgeweiler georgeweiler added No E2E Smoke Needed If the PR does not need E2E smoke test run and removed Run Smoke E2E Requires smoke E2E testing labels Jun 19, 2025
@georgeweiler georgeweiler disabled auto-merge June 19, 2025 19:43
@georgeweiler georgeweiler enabled auto-merge June 19, 2025 19:43
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
42.5% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

@georgeweiler georgeweiler added this pull request to the merge queue Jun 19, 2025
Merged via the queue into main with commit d81b941 Jun 19, 2025
40 of 42 checks passed
@georgeweiler georgeweiler deleted the feat/deposit/region-picker branch June 19, 2025 20:22
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2025
@metamaskbot metamaskbot added the release-7.50.0 Issue or pull request that will be included in release 7.50.0 label Jun 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.50.0 Issue or pull request that will be included in release 7.50.0 skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants