Skip to content

feat: deposit provider webview #16351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 20, 2025
Merged

Conversation

AxelGes
Copy link
Contributor

@AxelGes AxelGes commented Jun 13, 2025

Description

We need to show a Provider WebView where users can complete their payment using a card or Apple Pay. We'll monitor the URL for a redirect to our own domain that includes an orderId. Once we detect that redirect, we close the WebView and take the user to the order processing screen.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label Jun 13, 2025
@AxelGes AxelGes marked this pull request as ready for review June 19, 2025 00:16
@AxelGes AxelGes requested a review from a team as a code owner June 19, 2025 00:16
@AxelGes AxelGes added the Run Smoke E2E Requires smoke E2E testing label Jun 19, 2025
Copy link
Contributor

github-actions bot commented Jun 19, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a069c21
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fa8d3516-9cc6-495a-a0fe-1e9997415bfe

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@AxelGes AxelGes added No E2E Smoke Needed If the PR does not need E2E smoke test run and removed Run Smoke E2E Requires smoke E2E testing labels Jun 20, 2025
@AxelGes AxelGes added the No QA Needed Apply this label when your PR does not need any QA effort. label Jun 20, 2025
Copy link

@georgeweiler georgeweiler enabled auto-merge June 20, 2025 00:28
@georgeweiler georgeweiler added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Jun 20, 2025
@georgeweiler georgeweiler added this pull request to the merge queue Jun 20, 2025
Merged via the queue into main with commit dc9c1e4 Jun 20, 2025
59 of 63 checks passed
@georgeweiler georgeweiler deleted the feat/deposit/provider-webview branch June 20, 2025 00:49
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2025
@metamaskbot metamaskbot added the release-7.51.0 Issue or pull request that will be included in release 7.51.0 label Jun 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.51.0 Issue or pull request that will be included in release 7.51.0 skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-ramp issues related to Ramp features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants