feat: Base Wallet Details Screen #16344

owencraston · 2025-06-12T20:25:06Z

Description

This PR implements the basic wallet details screen. This feature is hidden behind a remote feature flag. This screen shows all the accounts that are tied to a wallet along with some other information...

wallet name
Total wallet balance (aggregate balances of all accounts in the wallet). This is not the aggregate balance of all your accounts, just the accounts that belong to the wallet
List of accounts that belong to that wallet with...
- the account name
- account icon (Blockies or Jazzicon)
- individual account balance

Designs:

Out of scope:

Social recovery
SRP
Adding an account
These changes will be made in subsequent PRs.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MUL-211

Manual testing steps

This feature is hidden behind a remote feature flag so to enable it you will either need to use a proxy (message me for details) or have this function return true as well as this one.
Create a wallet
Open the account list.
Since the multi-chain accounts state 1 feature flag is enabled, you should see your accounts grouped by wallet
click on the blue details icon beside the wallet name
it should take you to the wallet details screen
this screen should contain your wallet name, total wallet balance, and a list of your accounts in that wallet with their individual balances.
Click on an account should take you to that accounts details screen
clicking back from that screen should take you back to wallet details
Clicking back on the wallet details screen should take you back to the accounts list.

Screenshots/Recordings

Before

N/A

After

Untitled.mov

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-06-12T20:25:14Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov-commenter · 2025-06-17T20:55:22Z

Codecov Report

Attention: Patch coverage is 86.00000% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (MUL-199-update-account-list-to-support-grouping@a423183). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...Accounts/WalletDetails/BaseWalletDetails/index.tsx	80.00%	1 Missing and 5 partials ⚠️
app/components/Nav/App/App.tsx	50.00%	2 Missing ⚠️
.../EvmAccountSelectorList/EvmAccountSelectorList.tsx	86.66%	1 Missing and 1 partial ⚠️
...MultichainAccounts/WalletDetails/WalletDetails.tsx	33.33%	2 Missing ⚠️
...Accounts/WalletDetails/BaseWalletDetails/styles.ts	80.00%	0 Missing and 1 partial ⚠️
...nAccounts/WalletDetails/hooks/useWalletBalances.ts	95.23%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                                Coverage Diff                                 @@
##             MUL-199-update-account-list-to-support-grouping   #16344   +/-   ##
==================================================================================
  Coverage                                                   ?   71.24%           
==================================================================================
  Files                                                      ?     2620           
  Lines                                                      ?    55896           
  Branches                                                   ?     8614           
==================================================================================
  Hits                                                       ?    39825           
  Misses                                                     ?    13558           
  Partials                                                   ?     2513

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-06-17T21:04:38Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b425a93
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f8485e13-2394-4f28-8960-bd10ccce2446

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-06-18T12:00:58Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: af55b17
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a26f7e99-ab4e-46e7-ae0c-3a8a023fbd95

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

gantunesr

code looks good in general! will follow up with some manual testing

app/selectors/featureFlagController/multichainAccounts/enabledMultichainAccounts.ts

app/multichain-accounts/selectors/accountTreeController.test.ts

app/multichain-accounts/selectors/accountTreeController.ts

app/components/Views/MultichainAccounts/WalletDetails/utils/getInternalAccountsFromWallet.ts

app/components/Views/MultichainAccounts/WalletDetails/hooks/useWalletBalances.ts

github-actions · 2025-06-18T21:09:03Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e9a8d85
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/eb649f2f-5f48-4221-9a43-c40d15dec265

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2025-06-18T21:29:26Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.0% Coverage on New Code
8.0% Duplication on New Code

See analysis details on SonarQube Cloud

gantunesr

Code looks good, will do some manual testing

MarioAslau

Looks good!

gantunesr · 2025-06-20T01:09:26Z

I was not able to fully test the wallet details feature because of a few bugs that are not related to this PR, the first related to when you activate the feature flag for multichain accounts. I see that the list is empty and because of this bug I can't verify that the balances are properly calculated,

RPReplay_Final1750381517.MP4

The second bug is some UI/UX issues when looking into the account details, here's a video showing some of these issues,

RPReplay_Final1750375388.MP4

gantunesr

The changes on this PR looks good but we have to fix the bugs related to the other features

metamaskbot added the team-accounts label Jun 12, 2025

owencraston force-pushed the feat/mul-211 branch 2 times, most recently from 6910d83 to 8ce35f5 Compare June 13, 2025 16:18

owencraston changed the base branch from main to MUL-199-update-account-list-to-support-grouping June 13, 2025 16:18

owencraston force-pushed the feat/mul-211 branch 2 times, most recently from 1f47f66 to 629b58a Compare June 17, 2025 18:45

owencraston changed the title ~~Feat/mul 211~~ feat: Base Wallet Details Screen Jun 17, 2025

owencraston force-pushed the feat/mul-211 branch from 7ae3aff to a1accda Compare June 17, 2025 20:35

owencraston marked this pull request as ready for review June 17, 2025 21:04

owencraston requested review from a team as code owners June 17, 2025 21:04

owencraston added the Run Smoke E2E Requires smoke E2E testing label Jun 17, 2025

Base automatically changed from MUL-199-update-account-list-to-support-grouping to main June 17, 2025 21:16

owencraston requested a review from a team as a code owner June 17, 2025 21:16

owencraston requested a review from a team June 17, 2025 21:16

owencraston force-pushed the feat/mul-211 branch 4 times, most recently from 2b3be09 to af55b17 Compare June 18, 2025 12:00

owencraston added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 18, 2025

gantunesr reviewed Jun 18, 2025

View reviewed changes

owencraston force-pushed the feat/mul-211 branch from 7c67eb2 to c0d3ea7 Compare June 18, 2025 18:38

owencraston added 3 commits June 18, 2025 22:08

scaffold component

37c837e

edit wallet name

26c96f1

wallet balance

28223e2

owencraston added 11 commits June 18, 2025 22:08

render account Avatars

e94cb3f

render wallet balances

b5e61d2

account is touchable

e1058a4

basic unit tests

92a856d

Unit tests for getInternalAccountsFromWallet

e5d4a79

basic tests for useWalletBalances

55dd063

update test for accountTreeController

243f4a1

fix navigation

c500925

address simple comments

da9ad7c

remove default currency

004fe48

format with threshold

e9a8d85

owencraston force-pushed the feat/mul-211 branch from 1e5142e to e9a8d85 Compare June 18, 2025 21:08

owencraston added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 18, 2025

metamaskbot added the bitrise-result-ready label Jun 18, 2025

github-actions bot removed the bitrise-result-ready label Jun 18, 2025

gantunesr reviewed Jun 19, 2025

View reviewed changes

owencraston enabled auto-merge June 19, 2025 20:16

MarioAslau approved these changes Jun 19, 2025

View reviewed changes

gantunesr approved these changes Jun 20, 2025

View reviewed changes

owencraston added this pull request to the merge queue Jun 20, 2025

Merged via the queue into main with commit e47d97f Jun 20, 2025
49 of 56 checks passed

owencraston deleted the feat/mul-211 branch June 20, 2025 01:32

github-actions bot locked and limited conversation to collaborators Jun 20, 2025

metamaskbot added the release-7.51.0 Issue or pull request that will be included in release 7.51.0 label Jun 20, 2025

gantunesr assigned owencraston Jul 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: Base Wallet Details Screen #16344

feat: Base Wallet Details Screen #16344

owencraston commented Jun 12, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 12, 2025

Uh oh!

codecov-commenter commented Jun 17, 2025

Uh oh!

github-actions bot commented Jun 17, 2025 •

edited by metamaskbot

Loading

Uh oh!

github-actions bot commented Jun 18, 2025 •

edited by metamaskbot

Loading

Uh oh!

gantunesr left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 18, 2025 •

edited by metamaskbot

Loading

Uh oh!

sonarqubecloud bot commented Jun 18, 2025

Uh oh!

gantunesr left a comment

Uh oh!

MarioAslau left a comment

Uh oh!

gantunesr commented Jun 20, 2025

Uh oh!

gantunesr left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat: Base Wallet Details Screen #16344

feat: Base Wallet Details Screen #16344

Conversation

owencraston commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Out of scope:

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jun 12, 2025

Uh oh!

codecov-commenter commented Jun 17, 2025

Codecov Report

Uh oh!

github-actions bot commented Jun 17, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions bot commented Jun 18, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

gantunesr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 18, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

sonarqubecloud bot commented Jun 18, 2025

Quality Gate passed

Uh oh!

gantunesr left a comment

Choose a reason for hiding this comment

Uh oh!

MarioAslau left a comment

Choose a reason for hiding this comment

Uh oh!

gantunesr commented Jun 20, 2025

Uh oh!

gantunesr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

owencraston commented Jun 12, 2025 •

edited

Loading

github-actions bot commented Jun 17, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jun 18, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jun 18, 2025 •

edited by metamaskbot

Loading