feat: update account list to support grouping #16285

PatrykLucka · 2025-06-11T13:21:04Z

Description

This PR adds account grouping in accounts menu using the newly added AccountTreeController. All the changes are hidden by a feature flag

Related issues

Jira ticket: https://consensyssoftware.atlassian.net/browse/MUL-199

Manual testing steps

Make sure multichain accounts feature flag is enabled
Open accounts menu
Accounts should be grouped

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

socket-security · 2025-06-11T13:21:22Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/@metamask/account-tree-controller@0.1.1

View full report

github-actions · 2025-06-11T13:21:24Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2025-06-11T13:21:35Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 04705c7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/db53f064-90c3-488c-b225-89d58b608195

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

app/components/UI/EvmAccountSelectorList/EvmAccountSelectorList.styles.ts

app/components/UI/EvmAccountSelectorList/EvmAccountSelectorList.tsx

app/core/Authentication/Authentication.ts

app/multichain-accounts/selectors/accountTreeController.ts

github-actions · 2025-06-12T09:31:35Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 10d2739
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6d5c9ce8-c1b4-4554-9bee-f14b22716a60

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2025-06-12T09:36:01Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e6f78bd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/634a3d13-dc91-4c44-a74e-e62a92ec5910

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

app/selectors/featureFlagController/multichainAccounts/enabledMultichainAccounts.ts

app/core/Authentication/Authentication.ts

Cal-L

Left some comments

app/multichain-accounts/controllers/account-tree-controller/constants.ts

app/multichain-accounts/messengers/account-tree-controller-messenger/index.ts

app/components/UI/EvmAccountSelectorList/EvmAccountSelectorList.tsx

app/core/Authentication/Authentication.ts

sonarqubecloud · 2025-06-17T11:06:52Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
88.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-06-17T11:12:01Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a423183
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/492ee47f-68d7-477a-9b0a-e3c1b7e5165d

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L

Platform LGTM

Prithpal-Sooriya · 2025-06-23T19:29:33Z

app/components/UI/EvmAccountSelectorList/EvmAccountSelectorList.tsx

      renderItem={renderAccountItem}
+      renderSectionHeader={accountTreeSections ? renderSectionHeader : undefined}
+      renderSectionFooter={accountTreeSections ? renderSectionFooter : undefined}
      // Increasing number of items at initial render fixes scroll issue.
      initialNumToRender={999}


Best to change this from a SectionList/Flatlist to a FlashList..
This field specifically breaks virtualisation (it will only virtualise items after 999 items are rendered)

PatrykLucka self-assigned this Jun 11, 2025

PatrykLucka added the Run Smoke E2E Requires smoke E2E testing label Jun 11, 2025

metamaskbot added the team-accounts label Jun 11, 2025

PatrykLucka added the No QA Needed Apply this label when your PR does not need any QA effort. label Jun 11, 2025

PatrykLucka changed the title ~~Mul 199 update account list to support grouping~~ feat: update account list to support grouping Jun 11, 2025

metamaskbot added the bitrise-result-ready label Jun 11, 2025

github-actions bot removed the bitrise-result-ready label Jun 11, 2025

PatrykLucka marked this pull request as ready for review June 11, 2025 15:38

PatrykLucka requested review from a team as code owners June 11, 2025 15:38

PatrykLucka requested a review from a team June 11, 2025 15:38

gantunesr reviewed Jun 12, 2025

View reviewed changes

PatrykLucka force-pushed the MUL-199-update-account-list-to-support-grouping branch from 0a67af5 to 10d2739 Compare June 12, 2025 09:30

PatrykLucka added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 12, 2025

PatrykLucka force-pushed the MUL-199-update-account-list-to-support-grouping branch from 10d2739 to e6f78bd Compare June 12, 2025 09:35

PatrykLucka added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 12, 2025

infiniteflower previously approved these changes Jun 12, 2025

View reviewed changes

metamaskbot added the bitrise-result-ready label Jun 12, 2025

github-actions bot removed the bitrise-result-ready label Jun 12, 2025

gantunesr reviewed Jun 12, 2025

View reviewed changes

app/selectors/featureFlagController/multichainAccounts/enabledMultichainAccounts.ts Outdated Show resolved Hide resolved

owencraston reviewed Jun 12, 2025

View reviewed changes

app/core/Authentication/Authentication.ts Outdated Show resolved Hide resolved

owencraston reviewed Jun 12, 2025

View reviewed changes

app/core/Authentication/Authentication.ts Outdated Show resolved Hide resolved

Cal-L reviewed Jun 13, 2025

View reviewed changes

GustavoRSSilva previously approved these changes Jun 14, 2025

View reviewed changes

refactor: move initializeAccountTree to authStateMachine

a423183

PatrykLucka dismissed stale reviews from GustavoRSSilva, vinnyhoward, infiniteflower, and owencraston via a423183 June 17, 2025 10:49

PatrykLucka added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 17, 2025

PatrykLucka requested review from Cal-L, owencraston, GustavoRSSilva, vinnyhoward and infiniteflower June 17, 2025 11:11

metamaskbot added the bitrise-result-ready label Jun 17, 2025

github-actions bot removed the bitrise-result-ready label Jun 17, 2025

owencraston approved these changes Jun 17, 2025

View reviewed changes

vinnyhoward approved these changes Jun 17, 2025

View reviewed changes

Cal-L approved these changes Jun 17, 2025

View reviewed changes

infiniteflower approved these changes Jun 17, 2025

View reviewed changes

PatrykLucka enabled auto-merge June 17, 2025 20:53

PatrykLucka added this pull request to the merge queue Jun 17, 2025

Merged via the queue into main with commit ce2cb9a Jun 17, 2025
50 of 52 checks passed

PatrykLucka deleted the MUL-199-update-account-list-to-support-grouping branch June 17, 2025 21:16

github-actions bot locked and limited conversation to collaborators Jun 17, 2025

metamaskbot added the release-7.50.0 Issue or pull request that will be included in release 7.50.0 label Jun 17, 2025

Prithpal-Sooriya reviewed Jun 23, 2025

View reviewed changes

Uh oh!

feat: update account list to support grouping #16285

feat: update account list to support grouping #16285

Conversation

PatrykLucka commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

socket-security bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 11, 2025

Uh oh!

github-actions bot commented Jun 11, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 12, 2025

Bitrise

Uh oh!

github-actions bot commented Jun 12, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Cal-L left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Jun 17, 2025

Quality Gate passed

Uh oh!

github-actions bot commented Jun 17, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

Cal-L left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Prithpal-Sooriya Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PatrykLucka commented Jun 11, 2025 •

edited

Loading

socket-security bot commented Jun 11, 2025 •

edited

Loading

github-actions bot commented Jun 11, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jun 12, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jun 17, 2025 •

edited by metamaskbot

Loading