Skip to content

feat(deposit): adds order type to ramp processor #16210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 10, 2025
Merged

feat(deposit): adds order type to ramp processor #16210

merged 6 commits into from
Jun 10, 2025

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Jun 9, 2025 •
edited
Loading

Description

This PR adds a new type of Provider to the FiatOrder type: Deposit. The FiatOrder type is the shared common interface for orders placed using the Buy/Sell, Deposit and previous deprecated features. In this PR there was a code reorganization to hierarchically organize the orders processors and the analytics events/params.

Related issues

https://consensyssoftware.atlassian.net/browse/RAMPS-2504

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label Jun 9, 2025
@wachunei wachunei force-pushed the feat/deposit-order-type branch from 68b0c21 to 9d15328 Compare June 9, 2025 20:51
@wachunei wachunei added the Run Smoke E2E Requires smoke E2E testing label Jun 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9d15328
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cd40f177-9891-44ff-8173-5c7f27cb3e3a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Jun 10, 2025
@wachunei wachunei added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 10, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 269f029
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/70e10065-a62b-416d-98e0-9e958bfb2a36

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
45.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@wachunei wachunei marked this pull request as ready for review June 10, 2025 01:24
@wachunei wachunei requested a review from a team as a code owner June 10, 2025 01:24
@wachunei wachunei added the QA Passed QA testing has been completed and passed label Jun 10, 2025
@wachunei wachunei added this pull request to the merge queue Jun 10, 2025
Merged via the queue into main with commit 7d83173 Jun 10, 2025
53 of 60 checks passed
@wachunei wachunei deleted the feat/deposit-order-type branch June 10, 2025 16:32
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2025
@metamaskbot metamaskbot added the release-7.50.0 Issue or pull request that will be included in release 7.50.0 label Jun 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AxelGes AxelGes AxelGes approved these changes

Assignees
No one assigned
Labels
QA Passed QA testing has been completed and passed release-7.50.0 Issue or pull request that will be included in release 7.50.0 Run Smoke E2E Requires smoke E2E testing skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wachunei @AxelGes @metamaskbot