-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: update accounts-deps to enable KeyringRequest.origin
support
#15995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
accounts-deps
to enable KeyringRequest.origin
supportKeyringRequest.origin
support
dadee1c
to
df985f3
Compare
|
app/core/Engine/messengers/notifications/notification-services-controller-messenger.ts
Show resolved
Hide resolved
app/core/Engine/messengers/notifications/notification-services-controller-messenger.test.ts
Show resolved
Hide resolved
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15995 +/- ##
==========================================
- Coverage 70.73% 70.72% -0.01%
==========================================
Files 2570 2570
Lines 54858 54867 +9
Branches 8451 8454 +3
==========================================
+ Hits 38802 38806 +4
- Misses 13587 13589 +2
- Partials 2469 2472 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app/core/SnapKeyring/types.ts
✅
I ran some manual tests around the concerned areas and I could not notice any regression (hence de No-QA label) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we align as well the metamask/providers repo version? https://github.com/MetaMask/core/blob/d913b909a1473b1f446224dfdefc5141f0943ad3/packages/accounts-controller/package.json#L82
Good question! And I believe we should do it at some point! I'm just not sure what this implies though... I believe that's fine to keep it as-is for now, given that the previous version of the I also don't know who owns this kind of upgrade TBH. |
Description
Aligning some
accounts
deps to enable the newKeyringRequest.origin
support forKeyring.submitRequest
(from@metamask/keyring-api@18.0.0
) and the multichain API.Related issues
N/A
Manual testing steps
Using native swap/bridge (which rely on
keyring_submitRequest
):MM_BRIDGE_ENABLED="true"
on you env filesScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist