Skip to content

feat: update accounts-deps to enable KeyringRequest.origin support #15995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 5, 2025

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Jun 2, 2025

Description

Aligning some accounts deps to enable the new KeyringRequest.origin support for Keyring.submitRequest (from @metamask/keyring-api@18.0.0) and the multichain API.

Related issues

N/A

Manual testing steps

Using native swap/bridge (which rely on keyring_submitRequest):

  1. Enable MM_BRIDGE_ENABLED="true" on you env files
  2. Re-build and load the app
  3. Use an SRP that have some Solana "funds"
  4. Run the bridge flow using a Solana account
  5. Run the swap flow using a Solana account

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jun 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ccharly ccharly changed the title feat: update accounts-deps to enable KeyringRequest.origin support feat: update accounts-deps to enable KeyringRequest.origin support Jun 2, 2025
Copy link

socket-security bot commented Jun 2, 2025

@ccharly ccharly force-pushed the feat/keyring-request-origin-support branch from dadee1c to df985f3 Compare June 3, 2025 09:15
@ccharly ccharly self-assigned this Jun 3, 2025
@ccharly ccharly added the Run Smoke E2E Requires smoke E2E testing label Jun 3, 2025
Copy link
Contributor

github-actions bot commented Jun 3, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b1176c9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8b6aa588-ffac-4b24-9d07-22cd845d797b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@ccharly ccharly added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 3, 2025
Copy link
Contributor

github-actions bot commented Jun 3, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ba0b20e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3ecd219f-604d-4ddf-a728-dcf4de52dbe5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@ccharly ccharly marked this pull request as ready for review June 3, 2025 16:47
@ccharly ccharly requested review from a team as code owners June 3, 2025 16:47
@ccharly ccharly requested a review from a team June 3, 2025 16:47
@ccharly ccharly added Run Smoke E2E Requires smoke E2E testing and removed Run Smoke E2E Requires smoke E2E testing labels Jun 5, 2025
Copy link
Contributor

github-actions bot commented Jun 5, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 160c40f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ed40de59-7336-400d-8566-0f306772cbe6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.72%. Comparing base (ab54792) to head (160c40f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
app/core/Snaps/SnapsMethodMiddleware.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15995      +/-   ##
==========================================
- Coverage   70.73%   70.72%   -0.01%     
==========================================
  Files        2570     2570              
  Lines       54858    54867       +9     
  Branches     8451     8454       +3     
==========================================
+ Hits        38802    38806       +4     
- Misses      13587    13589       +2     
- Partials     2469     2472       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

sonarqubecloud bot commented Jun 5, 2025

Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app/core/SnapKeyring/types.ts

@ccharly ccharly added the No QA Needed Apply this label when your PR does not need any QA effort. label Jun 5, 2025
@ccharly
Copy link
Contributor Author

ccharly commented Jun 5, 2025

I ran some manual tests around the concerned areas and I could not notice any regression (hence de No-QA label)

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccharly
Copy link
Contributor Author

ccharly commented Jun 5, 2025

Should we align as well the metamask/providers repo version?

Good question! And I believe we should do it at some point!

I'm just not sure what this implies though... I believe that's fine to keep it as-is for now, given that the previous version of the accounts-controller was already depending on another @metamask/providers version that was not aligned with the one currently in use here 😅:

I also don't know who owns this kind of upgrade TBH.

@ccharly ccharly enabled auto-merge June 5, 2025 14:05
@ccharly ccharly added this pull request to the merge queue Jun 5, 2025
Merged via the queue into main with commit af16b05 Jun 5, 2025
50 of 56 checks passed
@ccharly ccharly deleted the feat/keyring-request-origin-support branch June 5, 2025 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2025
@metamaskbot metamaskbot added the release-7.50.0 Issue or pull request that will be included in release 7.50.0 label Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.50.0 Issue or pull request that will be included in release 7.50.0 Run Smoke E2E Requires smoke E2E testing team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants