Skip to content

feat: Adding alert for batched un-used approvals #15983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 4, 2025
Merged

feat: Adding alert for batched un-used approvals #15983

merged 14 commits into from
Jun 4, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Jun 2, 2025

Description

Adding alerts for un-used approvals in batched confirmations.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5047

Manual testing steps

Detailed here: MetaMask/metamask-extension#33237

Screenshots/Recordings

TODO

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jun 2, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jun 2, 2025
@jpuri jpuri marked this pull request as ready for review June 3, 2025 06:21
@jpuri jpuri requested a review from a team as a code owner June 3, 2025 06:21
@jpuri jpuri added the Run Smoke E2E Requires smoke E2E testing label Jun 4, 2025
Copy link
Contributor

github-actions bot commented Jun 4, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c0d6fe5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aa6fd3fc-53eb-486e-8807-223725224fbc

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

vinistevam
vinistevam previously approved these changes Jun 4, 2025
…edApprovalsAlert.ts

Co-authored-by: Vinicius Stevam <45455812+vinistevam@users.noreply.github.com>
Copy link

sonarqubecloud bot commented Jun 4, 2025

@jpuri jpuri enabled auto-merge June 4, 2025 15:18
@jpuri jpuri added No E2E Smoke Needed If the PR does not need E2E smoke test run and removed Run Smoke E2E Requires smoke E2E testing labels Jun 4, 2025
@jpuri jpuri added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit 3d5d158 Jun 4, 2025
43 of 48 checks passed
@jpuri jpuri deleted the approvals_alert branch June 4, 2025 15:46
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run release-7.48.0 Issue or pull request that will be included in release 7.48.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants