feat: 2.5 password change ui update #15891

ieow · 2025-05-30T10:32:54Z

Description

Change Password from the settings page. UI Update.

Related issues

Fixes:

Manual testing steps

Go to the App
Create Account
Go to the settings page -> Security Privacy -> Change Password.

Screenshots/Recordings

Before

After

Screen.Recording.2025-07-09.at.9.03.00.PM.mov

Screen.Recording.2025-07-09.at.9.00.37.PM.mov

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-05-30T10:33:06Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

remove unwanted lint changes

- Added OnboardingSheet component for user onboarding options. - Integrated AccountStatus component to handle existing account scenarios. - Updated navigation routes to include new onboarding flows. - Enhanced ChoosePassword component to support OAuth login success handling. - Updated localization files to include new strings for onboarding and account status. - Added tests for new components and updated existing tests for integration. This commit enhances the user experience during onboarding and account management by providing clear options and feedback for existing users.

…nd Authentication components

…ion and restoration

…ntication module

Co-authored-by: Ganesh Suresh Patra <ganesh.patra@consensys.net>

…s onboarding behavior

github-actions · 2025-07-10T07:34:51Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7c9507b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/79f94618-f91c-4858-a920-71c5c7c7ffeb

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor

Bug: Password Visibility Toggle Error

The password visibility logic is inverted for the confirm password field. When showPasswordIndex.includes(1) is true (meaning show password), secureTextEntry should be false, not true. The current logic secureTextEntry={this.state.showPasswordIndex.includes(1)} will hide the password when it should be shown and vice versa.

app/components/Views/ResetPassword/index.js#L899-L900

metamask-mobile/app/components/Views/ResetPassword/index.js

Lines 899 to 900 in f18f0f1

    
           onChangeText={this.setConfirmPassword} 
        
           secureTextEntry={this.state.showPasswordIndex.includes(1)}

app/components/Views/ResetPassword/index.js#L913-L917

metamask-mobile/app/components/Views/ResetPassword/index.js

Lines 913 to 917 in f18f0f1

    
           <Icon 
        
             name={ 
        
               this.state.showPasswordIndex.includes(1) 
        
                 ? IconName.Eye 
        
                 : IconName.EyeSlash

Fix in Cursor • Fix in Web

Bug: Password Visibility Logic Flipped

The password visibility logic is inverted. When showPasswordIndex.includes(0) is true (meaning show password), secureTextEntry should be false, not true. The current logic secureTextEntry={this.state.showPasswordIndex.includes(0)} will hide the password when it should be shown and vice versa.

app/components/Views/ResetPassword/index.js#L852-L853

metamask-mobile/app/components/Views/ResetPassword/index.js

Lines 852 to 853 in f18f0f1

    
           onChangeText={this.onPasswordChange} 
        
           secureTextEntry={this.state.showPasswordIndex.includes(0)}

app/components/Views/ResetPassword/index.js#L866-L870

metamask-mobile/app/components/Views/ResetPassword/index.js

Lines 866 to 870 in f18f0f1

    
           name={ 
        
             this.state.showPasswordIndex.includes(0) 
        
               ? IconName.Eye 
        
               : IconName.EyeSlash 
        
           }

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

github-actions · 2025-07-10T10:16:23Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f18f0f1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6d174a18-6c37-40b7-8236-1bd13814227b

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2025-07-10T10:26:30Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
1 Security Hotspot
86.6% Coverage on New Code
7.3% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbot added the team-onboarding Onboarding team label May 30, 2025

ieow mentioned this pull request Jun 20, 2025

feat: password change ui #16406

Closed

7 tasks

himanshuchawla009 assigned smgv Jun 25, 2025

ieow and others added 19 commits June 26, 2025 11:26

feat: clean up oauth service

6613043

remove unwanted lint changes

fix: remove build flag

d1465f8

fix: remove unused added assets

e08a4ca

fix: oauth config

9554498

chore: address comment

6a7aca4

fix : check for getBundleId

78bc655

fix: default ios google client bundleid

ee72c36

fix: remove oauth env from js.env.example

20b3a03

fix: add OTHER_METHODS_BUTTON selector to LoginView

f929f36

feat: remove seedless onboarding Build Flag from Login, Onboarding, a…

0eecdd9

…nd Authentication components

fix: update snapshot

375660c

test: enhance Login component tests with authentication scenarios

ebbeaab

fix: Failing tests in Onboarding view after merge

d365d5d

test: enhance App component tests with onboarding navigation scenarios

a4649ef

test: add tests for SOLANA_DISCOVERY_PENDING handling in wallet creat…

db0af35

…ion and restoration

test: add rehydrateSeedPhrase tests for seed phrase handling in Authe…

368ff2c

…ntication module

fix: seedless onboarding runtime env

6cea7a3

feat: seedless change password

bbbfdc1

ieow force-pushed the feat/seedless-change-pw branch from 978347b to bbbfdc1 Compare June 30, 2025 06:00

feat: change password ui update

426bc0c

Co-authored-by: Ganesh Suresh Patra <ganesh.patra@consensys.net>

ieow force-pushed the feat/seedless-change-pw-ui branch from f9e1627 to 426bc0c Compare June 30, 2025 06:05

smgv and others added 4 commits June 30, 2025 16:41

fix: test case update

320c8a3

test: enhance Onboarding tests with OAuth login scenarios and seedles…

4b17a02

…s onboarding behavior

fix: test update

4881cee

feat: init with default state when env is not enabled

e4109ff

github-actions bot removed the bitrise-result-ready label Jul 10, 2025

chaitanyapotti added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Jul 10, 2025

fix: address comment

7c9507b

ieow added Run Smoke E2E and removed Run Smoke E2E labels Jul 10, 2025

chaitanyapotti previously approved these changes Jul 10, 2025

View reviewed changes

github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jul 10, 2025

chaitanyapotti enabled auto-merge July 10, 2025 07:34

This comment was marked as outdated.

Sign in to view

chaitanyapotti and others added 2 commits July 10, 2025 16:05

Merge branch 'main' into feat/seedless-change-pw-ui

97b498e

feat: update snapshot

cc7a847

ieow dismissed chaitanyapotti’s stale review via cc7a847 July 10, 2025 10:09

Merge branch 'main' into feat/seedless-change-pw-ui

f18f0f1

cursor bot reviewed Jul 10, 2025

View reviewed changes

ieow added Run Smoke E2E and removed Run Smoke E2E labels Jul 10, 2025

metamaskbot added the bitrise-result-ready label Jul 10, 2025

github-actions bot removed the bitrise-result-ready label Jul 10, 2025

ieow requested a review from chaitanyapotti July 10, 2025 11:30

chaitanyapotti approved these changes Jul 10, 2025

View reviewed changes

chaitanyapotti added this pull request to the merge queue Jul 10, 2025

Merged via the queue into main with commit 7e8effd Jul 10, 2025
53 of 58 checks passed

chaitanyapotti deleted the feat/seedless-change-pw-ui branch July 10, 2025 11:50

github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Jul 10, 2025

github-actions bot locked and limited conversation to collaborators Jul 10, 2025

metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: 2.5 password change ui update #15891

feat: 2.5 password change ui update #15891

Uh oh!

ieow commented May 30, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 30, 2025

Uh oh!

github-actions bot commented Jul 10, 2025 •

edited by metamaskbot

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot left a comment

Uh oh!

github-actions bot commented Jul 10, 2025 •

edited by metamaskbot

Loading

Uh oh!

sonarqubecloud bot commented Jul 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

	onChangeText={this.setConfirmPassword}
	secureTextEntry={this.state.showPasswordIndex.includes(1)}

	<Icon
	name={
	this.state.showPasswordIndex.includes(1)
	? IconName.Eye
	: IconName.EyeSlash

	onChangeText={this.onPasswordChange}
	secureTextEntry={this.state.showPasswordIndex.includes(0)}

	name={
	this.state.showPasswordIndex.includes(0)
	? IconName.Eye
	: IconName.EyeSlash
	}

Uh oh!

feat: 2.5 password change ui update #15891

feat: 2.5 password change ui update #15891

Uh oh!

Conversation

ieow commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented May 30, 2025

Uh oh!

github-actions bot commented Jul 10, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Password Visibility Toggle Error

Bug: Password Visibility Logic Flipped

Uh oh!

github-actions bot commented Jul 10, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

sonarqubecloud bot commented Jul 10, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ieow commented May 30, 2025 •

edited

Loading

github-actions bot commented Jul 10, 2025 •

edited by metamaskbot

Loading

github-actions bot commented Jul 10, 2025 •

edited by metamaskbot

Loading