Skip to content

feat: Implement speed row in gas-fee-estimates #15880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025
Merged

feat: Implement speed row in gas-fee-estimates #15880

merged 3 commits into from
May 30, 2025

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented May 30, 2025

Description

This PR aims to implement "speed" row in gas fee estimates. See recording - we change gas values and speed row is changing.

Since these transactions are not reachable in the current user flow - adding no e2e test as it's not required.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5023

Manual testing steps

  1. Go send flow while transfer redesigned transfer confirmations enabled
  2. See speed row under network fee

Screenshots/Recordings

Before - no speed row

Screenshot 2025-05-27 at 12 03 35

After - with speed row

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-05-30.at.09.43.37.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner May 30, 2025 07:53
@OGPoyraz OGPoyraz added No QA Needed Apply this label when your PR does not need any QA effort. No E2E Smoke Needed If the PR does not need E2E smoke test run team-confirmations Push issues to confirmations team no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels May 30, 2025
Copy link

@OGPoyraz OGPoyraz added this pull request to the merge queue May 30, 2025
Merged via the queue into main with commit 8b2ff03 May 30, 2025
41 checks passed
@OGPoyraz OGPoyraz deleted the ogp/5023 branch May 30, 2025 09:29
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.48.0 Issue or pull request that will be included in release 7.48.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants