Skip to content

feat: add spam filtering for wallet_sendCalls #15853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 3, 2025
Merged

feat: add spam filtering for wallet_sendCalls #15853

merged 19 commits into from
Jun 3, 2025

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented May 29, 2025

Description

PR if doing some refactoring of origin-throttling spam detection and also enable it for wallet_sendCalls.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5024

Manual testing steps

  1. Enable 7702 locally
  2. Submit 5792 request 3 times and reject it
  3. Check the origin throttling modal appears

Screenshots/Recordings

Screenshot 2025-05-30 at 11 40 55 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label May 29, 2025
@jpuri jpuri marked this pull request as ready for review May 30, 2025 06:11
@jpuri jpuri requested review from a team as code owners May 30, 2025 06:11
@jpuri jpuri requested a review from a team May 30, 2025 06:11
@jpuri jpuri requested a review from ffmcgee725 June 2, 2025 14:30
@Tyschenko
Copy link
Contributor

image Why is the text in the component in the middle not centred?

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

OGPoyraz
OGPoyraz previously approved these changes Jun 2, 2025
ffmcgee725
ffmcgee725 previously approved these changes Jun 2, 2025
@jpuri jpuri dismissed stale reviews from ffmcgee725 and OGPoyraz via daf40ca June 2, 2025 16:59
@jpuri jpuri requested review from OGPoyraz and ffmcgee725 June 2, 2025 16:59
OGPoyraz
OGPoyraz previously approved these changes Jun 2, 2025
@jpuri jpuri requested review from jiexi and OGPoyraz June 3, 2025 03:33
Copy link

sonarqubecloud bot commented Jun 3, 2025

@jpuri jpuri enabled auto-merge June 3, 2025 09:33
@jpuri jpuri added the No E2E Smoke Needed If the PR does not need E2E smoke test run label Jun 3, 2025
@jpuri jpuri added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit 28d68f3 Jun 3, 2025
41 of 45 checks passed
@jpuri jpuri deleted the spam_filtering_fix branch June 3, 2025 13:07
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label Jun 3, 2025
@jpuri jpuri restored the spam_filtering_fix branch June 4, 2025 04:41
@jpuri jpuri deleted the spam_filtering_fix branch June 4, 2025 04:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run release-7.48.0 Issue or pull request that will be included in release 7.48.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants