-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: Contentful banner integration #15731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
41c11a5
to
e611b9a
Compare
app/components/UI/Carousel/fetchCarouselSlidesFromContentful.ts
Outdated
Show resolved
Hide resolved
app/components/UI/Carousel/fetchCarouselSlidesFromContentful.ts
Outdated
Show resolved
Hide resolved
app/components/UI/Carousel/fetchCarouselSlidesFromContentful.ts
Outdated
Show resolved
Hide resolved
e611b9a
to
e80e9fb
Compare
e80e9fb
to
607b12b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15731 +/- ##
==========================================
+ Coverage 69.64% 69.81% +0.16%
==========================================
Files 2483 2519 +36
Lines 53212 53789 +577
Branches 8139 8251 +112
==========================================
+ Hits 37058 37551 +493
- Misses 13760 13801 +41
- Partials 2394 2437 +43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@SocketSecurity ignore npm/contentful@11.5.23 We are using the contentful package for better fetching management of contentful content. If this is a blocker, we can fallback to just using the API |
Looking at the e2e failures, it is a known issue with confirmation smoke tests. I am confident that these changes do not touch the confirmation smoke tests. |
4e51c82
to
fd85e11
Compare
|
Description
This PR integrates Contentful into the mobile carousel, allowing promotional banners to be managed remotely rather than hardcoded in the app. Previously, all banners were statically defined in code. Now, they are dynamically fetched from Contentful, filtered based on activity dates, and rendered alongside predefined banners.
To keep the experience streamlined, I’ve also introduced a limit of 15 visible banners. This is an aesthetic decision to prevent the UI from being overwhelmed if too many are returned from Contentful.
The goal is to align the mobile experience with the existing MetaMask Extension Promotional banner and improve flexibility for teams.
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist