Skip to content

feat: Display tag with batched transaction count. #15408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
May 27, 2025
Merged

feat: Display tag with batched transaction count. #15408

merged 24 commits into from
May 27, 2025
+123 −9

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented May 16, 2025 •
edited
Loading

Description

On batched transaction page, Display tag with batched transaction count.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4948

Manual testing steps

  1. Enable 7702 locally
  2. Submit 5792 transaction on test-dapp
  3. Check tag with transaction count

Screenshots/Recordings

Screenshot 2025-05-16 at 9 19 50 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label May 16, 2025
@jpuri jpuri requested a review from a team as a code owner May 16, 2025 15:43
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri force-pushed the activity_list_changes branch from b74668c to 45981b1 Compare May 22, 2025 04:14
Base automatically changed from activity_list_changes to main May 26, 2025 13:31
@jpuri jpuri requested review from a team as code owners May 26, 2025 13:31
@jpuri jpuri requested a review from a team May 26, 2025 13:31
@jpuri jpuri requested a review from a team as a code owner May 26, 2025 13:31
@jpuri jpuri added the Run Smoke E2E Requires smoke E2E testing label May 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 26, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7b91d9d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4e38452a-5534-4b2e-8589-261db1ba55bf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

OGPoyraz
OGPoyraz requested changes May 26, 2025
View reviewed changes
jpuri and others added 3 commits May 27, 2025 09:10
@jpuri @OGPoyraz
Update app/components/Views/confirmations/components/title/batched-tr…
175d1e6 
…ansactions-tag/batched-transactions-tag.tsx

Co-authored-by: OGPoyraz <omergoktugpoyraz@gmail.com>
@jpuri
Update
1f20efb
@jpuri
Merge branch 'main' into batch_trxn_tag
d08df0a
@jpuri jpuri requested a review from OGPoyraz May 27, 2025 03:46
OGPoyraz
OGPoyraz reviewed May 27, 2025
View reviewed changes
jpuri and others added 3 commits May 27, 2025 11:16
@jpuri @OGPoyraz
Update locales/languages/en.json
402f069 
Co-authored-by: OGPoyraz <omergoktugpoyraz@gmail.com>
@jpuri @OGPoyraz
Update app/components/Views/confirmations/components/batched-transact…
2a818ae 
…ions-tag/batched-transactions-tag.tsx

Co-authored-by: OGPoyraz <omergoktugpoyraz@gmail.com>
@jpuri
update
6986b2a
@jpuri jpuri enabled auto-merge May 27, 2025 05:53
@jpuri jpuri added No E2E Smoke Needed If the PR does not need E2E smoke test run and removed Run Smoke E2E Requires smoke E2E testing labels May 27, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jpuri jpuri added this pull request to the merge queue May 27, 2025
Merged via the queue into main with commit c7f7e1f May 27, 2025
44 of 48 checks passed
@jpuri jpuri deleted the batch_trxn_tag branch May 27, 2025 06:23
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bschorchit bschorchit bschorchit left review comments

@OGPoyraz OGPoyraz OGPoyraz approved these changes

Assignees
No one assigned
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run release-7.48.0 Issue or pull request that will be included in release 7.48.0 team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpuri @OGPoyraz @bschorchit @metamaskbot