chore(runway): cherry-pick feat: cp-7.47.0 solana code fences #15385
+118
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## **Description**
- enables the Solana and Non-EVM code by moving the code fence flags to
the main set.
- this change makes all the Solana and Non-EVM features available in
main build.
> [!NOTE]
> The `keyring-snaps` is the code fence flag that allows for snaps like
the `solana`, `bitcoin`, any keyring snap to work, the Solana snap and
bitcoin snap are keyring-snaps.
> This code fence has all the broad/general code for non-evm snaps, and
then for specific network logic we have the solana, bitcoin etc...
## **Related issues**
Fixes: the current feature is under code fencing, only available in our
beta build, it has to be moved from beta to main set to be available in
the next release.
## **Manual testing steps**
```gherkin
Feature: Solana
Scenario: user opens new app install
Given the app is installed and wallet created
When user lands on wallet screen
Then user sees the new Solana feature announcement bottom sheet
And user sees in the accounts list "add Solana account"
And user sees in the network tab "Solana"
Scenario: user opens updated app
Given the app is updated with wallet already created
When user logs in
Then user sees the new Solana feature announcement bottom sheet
And user sees in the accounts list "add Solana account"
And user sees in the network tab "Solana"
```
## **Screenshots/Recordings**
### **Before**
#### Add account
<img width="340" alt="add account screenshot"
src="https://github.com/user-attachments/assets/2473cd0b-cfcd-4c4a-8f8e-73143e16315d"
/>
#### Select network
<img width="340" alt="select network screenshot"
src="https://github.com/user-attachments/assets/632f52cc-1013-4573-853d-178e372e220c"
/>
### **After**
#### New welcome bottom sheet
<img width="340" alt="new welcome modal screenshot"
src="https://github.com/user-attachments/assets/8124a0cd-e4b2-4daf-bdef-c08e7ff18516"
/>
#### Add account
<img width="340" alt="add account screenshot"
src="https://github.com/user-attachments/assets/5771e51a-6688-4d26-91df-7d7da622feba"
/>
#### Select network
<img width="340" alt="select network screenshot"
src="https://github.com/user-attachments/assets/54e3a06c-1d65-41dc-a2c2-eef8fb5a3c37"
/>
## **Pre-merge author checklist**
- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
---------
Co-authored-by: António Regadas <antonio.regadas@consensys.net>
Co-authored-by: yande <110056475+Andepande@users.noreply.github.com>
Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
the
team-runway-bot-deprecated
Contributor
|
NicolasMassart
approved these changes
May 16, 2025
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the main set.
main build.
Note
The
keyring-snapsis the code fence flag that allows for snaps likethe
solana,bitcoin, any keyring snap to work, the Solana snap andbitcoin snap are keyring-snaps.
This code fence has all the broad/general code for non-evm snaps, and
then for specific network logic we have the solana, bitcoin etc...
Related issues
Fixes: the current feature is under code fencing, only available in our
beta build, it has to be moved from beta to main set to be available in
the next release.
Manual testing steps
Screenshots/Recordings
Before
Add account
Select network
After
New welcome bottom sheet
Add account
Select network
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Co-authored-by: António Regadas antonio.regadas@consensys.net
Co-authored-by: yande 110056475+Andepande@users.noreply.github.com
Co-authored-by: Nico MASSART NicolasMassart@users.noreply.github.com 8ab1426