Skip to content

Conversation

@amitabh94
Copy link
Contributor

@amitabh94 amitabh94 commented May 15, 2025

Description

This PR adds a fee disclaimer text to the Bridge View to inform users about the 0.875% MetaMask fee. This change improves transparency by clearly communicating the fee structure to users before they proceed with a bridge transaction.

Related issues

Fixes: MMS-2343

Manual testing steps

  1. Open the Bridge View
  2. Verify that the fee disclaimer text "Includes 0.875% MM fee" appears below the quote details
  3. Confirm the text is properly aligned and styled
  4. Test with different screen sizes to ensure responsive layout

Screenshots/Recordings

Before

[Please add screenshot of Bridge View without fee disclaimer]

After

Screen.Recording.2025-05-15.at.5.50.33.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

amitabh94 added 2 commits May 15, 2025 17:26
- Introduced a new disclaimer text in the BridgeView to inform users about the 0.875% MetaMask fee.
- Updated styles to include padding for the disclaimer and adjusted layout for better visual alignment.
- Removed unnecessary bottom section styles to streamline the component's design.
@amitabh94 amitabh94 added QA Passed QA testing has been completed and passed Run Smoke E2E no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels May 15, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label May 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4fa295b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/764ae861-609e-4e0e-a73a-42edda8fa3f8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (c62b042) to head (f4a9d36).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15377      +/-   ##
==========================================
- Coverage   68.92%   68.91%   -0.01%     
==========================================
  Files        2394     2394              
  Lines       51403    51411       +8     
  Branches     7720     7724       +4     
==========================================
+ Hits        35430    35431       +1     
- Misses      13702    13709       +7     
  Partials     2271     2271              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Removed the fee disclaimer text from BridgeView and added it to QuoteDetailsCard for better modularity.
- Introduced new styles for the disclaimer text in QuoteDetailsCard to maintain visual consistency.
- Adjusted layout and animation duration for improved performance and user experience.
@amitabh94 amitabh94 marked this pull request as ready for review May 15, 2025 23:02
@amitabh94 amitabh94 requested a review from a team as a code owner May 15, 2025 23:02
@amitabh94 amitabh94 changed the title feat(bridge): add MetaMask fee disclaimer text to bridge view fix: cp-7.47.0 add MetaMask fee disclaimer text to bridge view May 15, 2025
@amitabh94 amitabh94 enabled auto-merge May 15, 2025 23:02
@sonarqubecloud
Copy link

@amitabh94 amitabh94 added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit ebce0f0 May 16, 2025
45 of 46 checks passed
@amitabh94 amitabh94 deleted the MMS-2343-add-metamask-fees-text-to-the-bridge-view branch May 16, 2025 00:17
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed QA Passed QA testing has been completed and passed release-7.48.0 Issue or pull request that will be included in release 7.48.0 team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants