Skip to content

feat(deposit): add routes and root route #15374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2025
Merged

feat(deposit): add routes and root route #15374

merged 3 commits into from
May 20, 2025

Conversation

wachunei
Copy link
Member

Description

This PR adds an initial Root Route to the deposit feature

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/RAMPS-2374 https://consensyssoftware.atlassian.net/browse/RAMPS-2375

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-ramp issues related to Ramp features label May 15, 2025
@wachunei wachunei added the Run Smoke E2E Requires smoke E2E testing label May 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 52a39f6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d6f6ea40-2efb-44f1-8f08-041389ada095

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@wachunei wachunei marked this pull request as ready for review May 15, 2025 22:35
@wachunei wachunei requested a review from a team as a code owner May 15, 2025 22:35
@wachunei wachunei added the No QA Needed Apply this label when your PR does not need any QA effort. label May 15, 2025
@wachunei wachunei changed the title feature(deposit): add root route feat(deposit): add routes and root route May 15, 2025
@wachunei wachunei added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2025
@wachunei wachunei added this pull request to the merge queue May 20, 2025
Merged via the queue into main with commit 0bc3aeb May 20, 2025
47 of 50 checks passed
@wachunei wachunei deleted the feature/deposit-routes branch May 20, 2025 19:31
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AxelGes AxelGes AxelGes approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.48.0 Issue or pull request that will be included in release 7.48.0 Run Smoke E2E Requires smoke E2E testing team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wachunei @AxelGes @metamaskbot