Skip to content

Conversation

@OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented May 14, 2025

Description

This PR aims to fix an issue when user puts an unexpected value into to field in send flow.

It appears from that the issue is thrown by toChecksumAddress because it doesn't expect any incomplete address. However in send flow UX we let user to type in address themselves.

To test this you can go SendTo page and put K for example - and see the crash. (Screenshot below is fixed version)

Labels
Adding skip-sonar-cloud as the raised issue was intentional.

Screenshot 2025-05-14 at 06 44 09

Related issues

Fixes: #15094

Manual testing steps

  1. Go to send flow
  2. Input an unexpected address
  3. Confirm warning shown - you shouldn't be proceed next step

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner May 14, 2025 04:55
@OGPoyraz OGPoyraz added the No QA Needed Apply this label when your PR does not need any QA effort. label May 14, 2025
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label May 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 86334a5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a5d33af6-6baf-4925-913a-249ca161c4e8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@OGPoyraz OGPoyraz added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label May 14, 2025
@OGPoyraz OGPoyraz added this pull request to the merge queue May 14, 2025
Merged via the queue into main with commit b22bfcc May 14, 2025
52 of 56 checks passed
@OGPoyraz OGPoyraz deleted the ogp/15094 branch May 14, 2025 06:26
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.48.0 Issue or pull request that will be included in release 7.48.0 skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Sentry] Error: This method only supports 0x-prefixed hex strings but input was: v

5 participants