Skip to content

test: disable portfolio connect e2e #15307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cortisiko merged 1 commit into from
May 14, 2025
Merged

test: disable portfolio connect e2e #15307

cortisiko merged 1 commit into from
May 14, 2025

Conversation

@cortisiko
Copy link
Member

@cortisiko cortisiko commented May 14, 2025

Description

The portfolio e2e test is causing instability in the smoke pipeline. This PR basically qurantine's the e2e.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko self-assigned this May 14, 2025
@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E labels May 14, 2025
@metamaskbot metamaskbot added the team-qa QA team label May 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 601621c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fe5b3443-fb5f-44ef-bed3-7b5bcbea4f0c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko enabled auto-merge May 14, 2025 00:34
chrisleewilcox
chrisleewilcox approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Cal-L
Cal-L approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cortisiko cortisiko added this pull request to the merge queue May 14, 2025
Merged via the queue into main with commit a9c3cfe May 14, 2025
58 of 61 checks passed
@cortisiko cortisiko deleted the Detox/quaratine-portfolio branch May 14, 2025 01:35
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees

@cortisiko cortisiko

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.48.0 Issue or pull request that will be included in release 7.48.0 team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cortisiko @chrisleewilcox @Cal-L @metamaskbot