Skip to content

fix: cp-7.47.0 bump bridge controllers and update quote response fields #15300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
infiniteflower merged 4 commits into from
May 15, 2025
Merged

fix: cp-7.47.0 bump bridge controllers and update quote response fields #15300

infiniteflower merged 4 commits into from
May 15, 2025

Conversation

@infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented May 13, 2025 •
edited
Loading

Description

This PR bumps the versions of bridge-controller and bridge-status-controller to fix an issue with the dev APIs and the field priceData

Related issues

Fixes:

Manual testing steps

  1. Go to Bridge
  2. Fetch a quote
  3. Quote should load successfully

Screenshots/Recordings

Before

After

n/a, non-user facing change

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Swaps and Bridge team label May 13, 2025
@infiniteflower infiniteflower marked this pull request as ready for review May 13, 2025 17:56
@infiniteflower infiniteflower requested a review from a team May 13, 2025 17:56
@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 76ab1ae
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/06df1792-232a-4714-b10e-6ac7081d52ca

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@socket-security
Copy link

socket-security bot commented May 13, 2025 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​bridge-status-controller@​18.0.0 ⏵ 20.0.090 +71007599 +1100
Updatednpm/​@​metamask/​bridge-controller@​21.0.0 ⏵ 23.0.0911007699 +1100

View full report

@infiniteflower infiniteflower requested a review from a team as a code owner May 14, 2025 15:04
@infiniteflower infiniteflower added QA Passed QA testing has been completed and passed Run Smoke E2E and removed Run Smoke E2E labels May 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: fd7d355
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9ed638ef-9972-42b3-b5ee-d66cdb2decdf

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

amitabh94
amitabh94 previously approved these changes May 14, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9540076
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ea15661a-05ea-41aa-8c10-ca6fec684543

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@infiniteflower infiniteflower enabled auto-merge May 14, 2025 18:14
@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b912156
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/76d18f3c-2f7e-4d42-8141-7712ac6e131b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@amitabh94 amitabh94 changed the title chore: bump versions of bridge and bridge status controllers chore: cp-7.47.0 bump versions of bridge and bridge status controllers May 15, 2025
@amitabh94 amitabh94 changed the title chore: cp-7.47.0 bump versions of bridge and bridge status controllers fix: cp-7.47.0 update quote response fields May 15, 2025
@amitabh94 amitabh94 moved this to Needs dev review in PR review queue May 15, 2025
@amitabh94 amitabh94 changed the title fix: cp-7.47.0 update quote response fields fix: cp-7.47.0 bump bridge controllers and update quote response fields May 15, 2025
Cal-L
Cal-L approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue May 15, 2025
@infiniteflower infiniteflower added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit 144352d May 15, 2025
55 of 57 checks passed
@infiniteflower infiniteflower deleted the chore/bridge-priceData-version-bump branch May 15, 2025 21:23
@github-project-automation github-project-automation bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue May 15, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amitabh94 amitabh94 amitabh94 approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed release-7.48.0 Issue or pull request that will be included in release 7.48.0 team-swaps-and-bridge Swaps and Bridge team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@infiniteflower @Cal-L @amitabh94 @metamaskbot