-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: (cp-7.46.0) network switcher - use additional checks for non-evm networks #15283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+72
−1
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6297691
fix: network switcher - use additional checks for non-evm networks
Prithpal-Sooriya 1976ebc
Merge branch 'main' of github.com:MetaMask/metamask-mobile into fix/e…
Prithpal-Sooriya 179482b
Merge branch 'main' of github.com:MetaMask/metamask-mobile into fix/e…
Prithpal-Sooriya 3f9267b
test: add test to cover removing CAIP-2 networks in the custom networ…
Prithpal-Sooriya ad98cc1
Merge branch 'main' of github.com:MetaMask/metamask-mobile into fix/e…
Prithpal-Sooriya 0b2ed59
Merge branch 'main' into fix/ensure-toHex-uses-evm-networks
Prithpal-Sooriya 8f9dadb
Merge branch 'main' into fix/ensure-toHex-uses-evm-networks
Prithpal-Sooriya 0940ee0
Merge branch 'main' into fix/ensure-toHex-uses-evm-networks
NicolasMassart 3a84fb3
refactor: update test utilities and test name
Prithpal-Sooriya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
70 changes: 70 additions & 0 deletions
70
.../Views/Settings/NetworksSettings/NetworkSettings/CustomNetworkView/CustomNetwork.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| import React from 'react'; | ||
| import { backgroundState } from '../../../../../../util/test/initial-root-state'; | ||
| import renderWithProvider from '../../../../../../util/test/renderWithProvider'; | ||
| import CustomNetwork from './CustomNetwork'; | ||
| import { CustomNetworkProps } from './CustomNetwork.types'; | ||
| import { PopularList } from '../../../../../../util/networks/customNetworks'; | ||
|
|
||
| const getMockState = () => ({ engine: { backgroundState } }); | ||
|
|
||
| jest.mock('@react-navigation/native', () => { | ||
| const actualNav = jest.requireActual('@react-navigation/native'); | ||
| return { | ||
| ...actualNav, | ||
| useNavigation: () => ({ | ||
| navigate: jest.fn(), | ||
| }), | ||
| }; | ||
| }); | ||
|
|
||
| describe('CustomNetwork component', () => { | ||
| const getMockCustomNetworkProps = ( | ||
| overrides?: Partial<CustomNetworkProps>, | ||
| ) => { | ||
| const mockCloseNetworkModal = jest.fn(); | ||
| const mockShowNetworkModal = jest.fn(); | ||
| const mockCustomNetworkProps: CustomNetworkProps = { | ||
| showPopularNetworkModal: false, | ||
| isNetworkModalVisible: false, | ||
| closeNetworkModal: mockCloseNetworkModal, | ||
| selectedNetwork: { | ||
| chainId: '0x1', | ||
| nickname: 'Ethereum Mainnet', | ||
| rpcUrl: 'https://mainnet.infura.io/v3/your-api-key', | ||
| ticker: 'ETH', | ||
| rpcPrefs: { | ||
| blockExplorerUrl: 'https://etherscan.io', | ||
| }, | ||
| }, | ||
| showNetworkModal: mockShowNetworkModal, | ||
| shouldNetworkSwitchPopToWallet: false, | ||
| ...overrides, | ||
| }; | ||
| return mockCustomNetworkProps; | ||
| }; | ||
|
|
||
| it('filters out CAIP-2 networks when showing all networks (included added networks)', () => { | ||
| const props = getMockCustomNetworkProps({ showAddedNetworks: true }); | ||
| const mockState = getMockState(); | ||
| const { getByText, queryByText } = renderWithProvider( | ||
| <CustomNetwork {...props} />, | ||
| { | ||
| state: mockState, | ||
| }, | ||
| ); | ||
|
|
||
| const additionalNetworksVisible = PopularList.map((p) => p.nickname); | ||
| additionalNetworksVisible.forEach((name) => { | ||
| expect(getByText(name)).toBeOnTheScreen(); | ||
| }); | ||
|
|
||
| Object.values( | ||
| Object.values( | ||
| mockState.engine.backgroundState.MultichainNetworkController | ||
| .multichainNetworkConfigurationsByChainId, | ||
| ), | ||
| ).forEach((n) => { | ||
| expect(queryByText(n.name)).not.toBeOnTheScreen(); | ||
| }); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.