Skip to content

Conversation

@wachunei
Copy link
Member

@wachunei wachunei commented May 7, 2025

Description

This PR upgrades on-ramp-sdk to 2.1.8 which includes a small fix for custom actions in sell responses

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added team-ramp issues related to Ramp features Run Smoke E2E labels May 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e987301
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f613c41a-9bc3-4f8c-8539-3436bd759ce8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@socket-security
Copy link

socket-security bot commented May 7, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​consensys/​on-ramp-sdk@​2.1.7 ⏵ 2.1.88810097100 +180

View full report

@wachunei wachunei added the QA Passed QA testing has been completed and passed label May 7, 2025
@wachunei wachunei marked this pull request as ready for review May 7, 2025 14:47
@wachunei wachunei requested a review from a team May 7, 2025 14:47
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.46%. Comparing base (5113000) to head (49a70d9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15212   +/-   ##
=======================================
  Coverage   68.46%   68.46%           
=======================================
  Files        2372     2372           
  Lines       51275    51275           
  Branches     7634     7634           
=======================================
+ Hits        35103    35105    +2     
+ Misses      13942    13940    -2     
  Partials     2230     2230           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 49a70d9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f40cfa7d-505b-430e-83cc-9b83e04b486d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ab85c1f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/efdde583-7d47-4c4f-a16a-bce563de2503

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2025

@wachunei wachunei added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit 1e21ed6 May 7, 2025
49 of 51 checks passed
@wachunei wachunei deleted the chore/ramp-sdk-2.1.8 branch May 7, 2025 21:25
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA Passed QA testing has been completed and passed release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-ramp issues related to Ramp features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants