Skip to content

Conversation

@ccharly
Copy link
Contributor

@ccharly ccharly commented May 7, 2025

Description

The ADD_SNAP_ACCOUNT was not starting at the right spot. This flow is async, and starts when we submit a request to the Snap, which will then notify the Snap keyring of the created account, and finally the Snap account will get persisted asynchronously.

Also added a new ADD_HD_ACCOUNT perf event to be able to compare both timing.

Finally, I've added a small debug log that could be helpful to get some perf timing without having to go through our visualization tool (we can discuss if that's a good thing or not, I just find it handy for now).

Related issues

N/A

Manual testing steps

  1. Create a Solana account (you should see some timing in the console now)
  2. Create an HD account (similar logs should be on the console)

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ccharly ccharly added team-accounts-framework Accounts Framework team area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. labels May 7, 2025
@ccharly ccharly requested a review from tommasini May 7, 2025 12:30
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ccharly ccharly added the No QA Needed Apply this label when your PR does not need any QA effort. label May 7, 2025
@ccharly ccharly linked an issue May 7, 2025 that may be closed by this pull request
@ccharly ccharly marked this pull request as ready for review May 7, 2025 14:13
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d306388
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/afd44d80-47e5-4f5e-af8d-0c39d12f5c66

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2025

@ccharly ccharly added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit c66b660 May 7, 2025
46 of 48 checks passed
@ccharly ccharly deleted the perf/add-hd-account-tracing branch May 7, 2025 15:22
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. No QA Needed Apply this label when your PR does not need any QA effort. release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-accounts-framework Accounts Framework team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: performance degradation during account creation

4 participants