Skip to content

Conversation

@sethkfman
Copy link
Contributor

Description

The mobile app doesn't currently support rc feature flags. This is important to enable flag testing in release candidate builds. Two new workflows have been added to enable RC builds and will need to be integrate into the Runway workflow.

  • build_android_rc_and_upload_sourcemaps
  • build_ios_rc_and_upload_sourcemaps

Related issues

Fixes:

Manual testing steps

  1. Build Android or iOS version
  2. Modify feature flag on the main-rc
  3. See flag triggered on app

Screenshots/Recordings

Before

After

iOS: https://app.bitrise.io/build/ecceb3d4-d48f-49b9-8dc4-51f22b79c35a
Android: https://app.bitrise.io/build/6a6d6368-5d3c-40e3-849f-485abc7172f0

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sethkfman sethkfman requested a review from a team May 6, 2025 20:44
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label May 6, 2025
@sethkfman sethkfman added team-dev-ops DevOps team No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform Mobile Platform team No E2E Smoke Needed and removed team-mobile-platform Mobile Platform team labels May 6, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2025

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@sethkfman sethkfman added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit 5113000 May 7, 2025
40 checks passed
@sethkfman sethkfman deleted the chore/create-main-rc-workflow branch May 7, 2025 14:57
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-dev-ops DevOps team team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants