Skip to content

Conversation

@OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented May 4, 2025

Description

This PR aims to implement useClearConfirmationOnBackSwipe for transfer confirmations.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4815

Manual testing steps

Only possible to test it out via setting FEATURE_FLAG_REDESIGNED_TRANSFER to true, so can be skipped manual test for now.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner May 4, 2025 10:05
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label May 4, 2025
@OGPoyraz OGPoyraz added No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed Run Smoke E2E labels May 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c88107a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7a1c0c80-0d10-4d23-b535-ce9abf2a6e58

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: df1484d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dcd085d4-f5ef-4c7b-a3ad-5473ae1db29f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2025

@OGPoyraz OGPoyraz added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit 465c80e May 7, 2025
49 of 51 checks passed
@OGPoyraz OGPoyraz deleted the ogp/4815 branch May 7, 2025 06:02
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants