-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
refactor: Refactor connection UI MultiSelector components to be more generic #14941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ctor/NetworkConnectMultiSelector.test.tsx
…d logic begone ? Discuss
The base branch was changed.
|
…hain' into jl/refactor-connection-ui-multichain
|
adonesky1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
vinnyhoward
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled down and tested. Works as expected



NOTE: This branch name is inaccurate. This PR only covers refactor work listed below. It does not add multichain support
Description
AccountConnectMultiSelectorandNetworkConnectMultiSelectorcomponents to be more genericAccountConnectandAccountPermissionviews to use the updated components aboveThis is prereq work to CAIP-ifying the connection UI
Related issues
Fixes:
Manual testing steps
No user facing changes
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist