Skip to content

Conversation

@jiexi
Copy link
Contributor

@jiexi jiexi commented Apr 28, 2025

NOTE: This branch name is inaccurate. This PR only covers refactor work listed below. It does not add multichain support

Description

  • Refactors the AccountConnectMultiSelector and NetworkConnectMultiSelector components to be more generic
  • Refactors the AccountConnect and AccountPermission views to use the updated components above

This is prereq work to CAIP-ifying the connection UI

Related issues

Fixes:

Manual testing steps

No user facing changes

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Base automatically changed from feat/caip-25-refactor to main May 6, 2025 15:57
@adonesky1 adonesky1 dismissed stale reviews from darkwing and themself May 6, 2025 15:57

The base branch was changed.

@jiexi jiexi requested review from a team as code owners May 6, 2025 15:57
@jiexi jiexi requested a review from a team May 6, 2025 15:57
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1deca17
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/932a4b3c-9a3a-4b90-b35b-20156b4fb3e4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jiexi jiexi added the No QA Needed Apply this label when your PR does not need any QA effort. label May 7, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 7, 2025

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled down and tested. Works as expected

@jiexi jiexi added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit 884a0c6 May 7, 2025
43 of 44 checks passed
@jiexi jiexi deleted the jl/refactor-connection-ui-multichain branch May 7, 2025 21:30
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants