You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds migration 082 to reset the phishingLists array in the PhishingController while preserving all other controller state.
Reason for change: We have introduced real-time dapp scanning to replace the traditional eth phishing detection functionality. As a result, the large local phishing lists are no longer needed, which have been contributing to memory issues on low-end devices and increased app startup time.
Improvement/solution: This targeted migration removes the outdated phishing lists data by resetting only the phishingLists array to empty, while preserving all other user preferences and controller state. This approach:
Reduces app memory footprint and state size
Improves app startup performance
Prevents memory-related issues on low-end devices
Maintains all user customizations like whitelisted sites
Related issues
Fixes: [Issue number/link]
Manual testing steps
Install previous version of the app and observe app startup time
Check memory usage with the old phishing lists in place
Update to version with this migration
Verify improved startup time and reduced memory usage
Confirm dapp security scanning still functions correctly with the real-time implementation
Screenshots/Recordings
Before
N/A - Performance improvement in background process
After
N/A - Performance improvement in background process
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
AugmentedMode
changed the title
feat: add migration 074 to reset PhishingController phishingLists
feat: add migration 079 to reset PhishingController phishingLists
May 22, 2025
AugmentedMode
changed the title
feat: add migration 079 to reset PhishingController phishingLists
feat: add migration 082 to reset PhishingController phishingLists
May 28, 2025
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-performanceIssues relating to slowness of app, cpu usage, and/or blank screens.No E2E Smoke NeededIf the PR does not need E2E smoke test runQA PassedQA testing has been completed and passedrelease-7.48.0Issue or pull request that will be included in release 7.48.0team-product-safetyPush issues to Product Safety team
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AugmentedMode
changed the title
metamaskbot
added
the
release-7.48.0
dylanbutler1
added
the
area-performance
Description
This PR adds migration 082 to reset the
phishingListsarray in the PhishingController while preserving all other controller state.Reason for change: We have introduced real-time dapp scanning to replace the traditional eth phishing detection functionality. As a result, the large local phishing lists are no longer needed, which have been contributing to memory issues on low-end devices and increased app startup time.
Improvement/solution: This targeted migration removes the outdated phishing lists data by resetting only the
phishingListsarray to empty, while preserving all other user preferences and controller state. This approach:Related issues
Fixes: [Issue number/link]
Manual testing steps
Screenshots/Recordings
Before
N/A - Performance improvement in background process
After
N/A - Performance improvement in background process
Pre-merge author checklist
Pre-merge reviewer checklist