Skip to content

Conversation

@jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 24, 2025

Description

Fix request from url displayed for signatures. Wrong url is spamming sentry.

Related issues

Fixes: #13580

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added Run Smoke E2E team-confirmations Push issues to confirmations team labels Feb 24, 2025
@jpuri jpuri requested a review from a team as a code owner February 24, 2025 05:14
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 381905e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4576cf60-18bd-4105-bece-d14119b79469

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit ea0c687 Feb 24, 2025
42 of 43 checks passed
@jpuri jpuri deleted the request_url_fix branch February 24, 2025 12:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.42.0 Issue or pull request that will be included in release 7.42.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Sentry] TypeError: Invalid URL: ssi.sosovalue.com

5 participants