chore: cherry-pick #13590 #13648
Merged
chore: cherry-pick #13590 #13648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> fixes: #12857 ## **Description** This PR corrects a linting issue and accidental typo in two files which could cause our banner to render full width instead of with the intended marginHorizontal. We can see that both files where this typo exists has corresponding references to this style which will be affected (by not being applied). The codebase has been searched for all instances and these two were flagged. It's obvious by looking at the two changes that they need to be camelCase ## **Related issues** Fixes: ## **Manual testing steps** 1. Trigger STX migration and use ApproveTransactionReview by using the testdapp in mobile to deploy a smart contract. 2. Ensure that the Smart TransactionMigrationBanner displays with proper margin and does not take up full width in this view. See screenshots where BEFORE is the existing state with the typo causing the banner to not display properly in the TransactionReview and the ApproveTransactionReview, views and the AFTER is with the fix to use camelCase as intended. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <img width="300" alt="STXBannerFullWidth" src="https://github.com/user-attachments/assets/fcdcd746-3a6c-45d3-9b99-426a2650c43f" /> ### **After** <img width="300" alt="STXBannerMargin" src="https://github.com/user-attachments/assets/47ddc977-b517-4cd4-84e0-c3a9ef4ef8b4" /> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
MarioAslau
approved these changes
Feb 20, 2025
Contributor
Author
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks #13590