Skip to content

Conversation

@jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 20, 2025

Description

PR fixes error thrown from DisplayURL component. I found that error throw during rendering phase get propagated despite try/catch block. The PR wraps code in useEffect hook.

Related issues

Fixes: #13580

Manual testing steps

  1. Go to dapp not using https:// only using http://
  2. Submit signature
  3. Check displayed url

Screenshots/Recordings

TODO

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added Run Smoke E2E team-confirmations Push issues to confirmations team labels Feb 20, 2025
@jpuri jpuri requested a review from a team as a code owner February 20, 2025 04:55
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 88ff7fc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ba742622-a2fb-469d-9857-47b512e73b63

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud
Copy link

@jpuri jpuri added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit b6b3cdc Feb 20, 2025
46 of 48 checks passed
@jpuri jpuri deleted the sentry_issue_fix branch February 20, 2025 09:22
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.42.0 Issue or pull request that will be included in release 7.42.0 team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Sentry] TypeError: Invalid URL: ssi.sosovalue.com

4 participants