Skip to content

Conversation

@vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Feb 14, 2025

Description

Added CFBundleIconName to Info.plist to fix TestFlight validation error. This was required because:

  1. Recent app icon changes switched from device-specific format (iphone/ipad) to universal format (platform: "ios")
  2. The new universal icon format requires explicit icon configuration in Info.plist
  3. Added:
<key>CFBundleIconName</key>
<string>AppIcon</string>

This matches our asset catalog name AppIcon.appiconset and should resolve the TestFlight upload error.

Related issues

Fixes:

Manual testing steps

  1. View ios/MetaMask/Info.plist to confirm CFBundleIconName is there

Screenshots/Recordings

NA

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward requested a review from a team as a code owner February 14, 2025 18:03
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-core-extension-ux Core Extension UX team label Feb 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3cc360d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46db7824-2d06-47ce-8b96-4249364d089a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud
Copy link

@vinnyhoward vinnyhoward added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit 7de1583 Feb 14, 2025
47 of 50 checks passed
@vinnyhoward vinnyhoward deleted the plist-appicon-update branch February 14, 2025 18:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.42.0 Issue or pull request that will be included in release 7.42.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants