Skip to content

Conversation

@cortisiko
Copy link
Member

Description

This PR removes an obsolete e2e test. Furthermore, the CHAIN_PERMISSIONS: FALSE flag in the regression pipeline was removed since chain permissions are on by default.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko self-assigned this Feb 14, 2025
@cortisiko cortisiko requested a review from a team February 14, 2025 00:19
@cortisiko cortisiko requested a review from a team as a code owner February 14, 2025 00:19
@metamaskbot metamaskbot added the team-qa QA team label Feb 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 900e89f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/26d67605-fc95-4e29-bf60-11d81172dc4c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko enabled auto-merge February 14, 2025 02:36
@sonarqubecloud
Copy link

@cortisiko cortisiko added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit e04f7c8 Feb 14, 2025
39 checks passed
@cortisiko cortisiko deleted the Detox/remove-old-permission-system-tests branch February 14, 2025 03:10
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.42.0 Issue or pull request that will be included in release 7.42.0 team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants